feat: support for large in-app messages #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report between this PR and the main branch |
mrehan27
reviewed
Oct 28, 2024
| @@ -7,13 +7,13 @@ protocol NetworkSettings { | |||
| struct NetworkSettingsProduction: NetworkSettings { | |||
| let queueAPI = "https://gist-queue-consumer-api.cloud.gist.build" | |||
| let engineAPI = "https://engine.api.gist.build" | |||
| let renderer = "https://renderer.gist.build/2.0" | |||
| let renderer = "https://renderer.gist.build/3.0" | |||
There was a problem hiding this comment.
Not entirely sure about the impact here, but my assumption is that posting JSON might only work with this version of renderer and not the old one. And I believe it should still handle messages from both legacy editor and new editor without issues. However, just to be safe, can you please confirm if this change was intentional? It would also be helpful to mention this on linked ticket or in Slack so the squad is aligned and aware of the update.
There was a problem hiding this comment.
not sure i get it? 3.0 handles the new way of rendering and 2.0 still handles the old way. So the folks who had older SDK version would keep on using 2.0 until they use 3.0?
There was a problem hiding this comment.
This was exactly my question, whether 3.0 enforces any new requirements when composing in-app messages or if it's fully compatible with existing ones. From your response, it sounds like it is fully compatible. My only request here is to explicitly mention this update on ticket for reference, as I don't see it mentioned in ticket description or comments. I think calling this out clearly would be good for transparency.
mrehan27
approved these changes
Nov 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
==========================================
- Coverage 64.58% 63.08% -1.50%
==========================================
Files 149 149
Lines 6172 6196 +24
==========================================
- Hits 3986 3909 -77
- Misses 2186 2287 +101 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
## [3.6.0](3.5.1...3.6.0) (2024-11-13) ### Features * support for large in-app messages ([#831](#831)) ([3731f68](3731f68))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: MBL-547: Bug: Large in-app messages not getting delivered
changes:
Before: You were overriding window.parent.postMessage, which altered how postMessage worked, potentially affecting other code on the page.
Now: You are listening for messages, allowing all normal JavaScript behavior to continue while capturing the data you need.