refactor: update sample apps with newer RN syntax #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levibostian
commented
Oct 27, 2023
Comment on lines
+2
to
+5
| #import <FCMSampleApp-Swift.h> | ||
| #import <React/RCTLinkingManager.h> | ||
| #import <React/RCTBundleURLProvider.h> | ||
| #import <FirebaseCore.h> |
There was a problem hiding this comment.
These imports were moved here from AppDelegate.h file.
These imports are not mentioned in our SDK docs code samples for a valid AppDelegate.h file. I think it's best for our sample apps to align with our docs so I moved imports to this file.
levibostian
commented
Oct 27, 2023
Comment on lines
2
to
+5
| #import <UIKit/UIKit.h> | ||
| #import <UserNotifications/UNUserNotificationCenter.h> | ||
| #import <UserNotifications/UserNotifications.h> | ||
|
|
||
| @interface AppDelegate : UIResponder <UIApplicationDelegate, RCTBridgeDelegate, UNUserNotificationCenterDelegate> | ||
|
|
||
| @property (nonatomic, strong) UIWindow *window; | ||
| @interface AppDelegate: RCTAppDelegate<UNUserNotificationCenterDelegate> |
There was a problem hiding this comment.
This is the major change in this PR. Updating syntax to align with our docs changes.
ami-aman
approved these changes
Nov 1, 2023
ami-aman
reviewed
Nov 1, 2023
| </SafeAreaView> | ||
| </UserStateContext.Provider> | ||
| </CustomerIoSdkContext.Provider> | ||
| <GestureHandlerRootView style={{ flex: 1 }}> |
There was a problem hiding this comment.
These changes were indeed required ! Thanks for making this PR!
Shahroz16
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pod updatein sample apps.