feat: fetch currently stored device token using JS method #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shahroz16
approved these changes
Nov 1, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
## [3.3.0](3.2.1...3.3.0) (2023-11-01) ### Features * fetch currently stored device token using JS method ([#216](#216)) ([482f780](482f780))
levibostian
reviewed
Nov 1, 2023
Comment on lines
+128
to
+132
| if (deviceToken != null) { | ||
| promise.resolve(deviceToken) | ||
| } else { | ||
| promise.reject("device_token_not_found", "The device token is not available.") | ||
| } |
There was a problem hiding this comment.
I would have preferred to have the Promise resolve null instead of reject when the native device token is null.
A device not yet having a device token is not an error, IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/customerio/issues/issues/11181
Provides a feature to fetch currently stored device token and returns as a string in a promise. This feature helps getting device tokens for FCM & APN for iOS and FCM token for Android. The following is the use case of the feature:
How to test this feature?