Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase opened metrics reliability and 3rd party push SDK compatibility #236

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

levibostian
Copy link
Contributor

@levibostian levibostian commented Feb 9, 2024

Install the latest iOS SDK version which includes automatic push click handling. Which gives the RN SDK great benefits such as: increased opened push metrics reliability and better compatibility with 3rd party RN push SDKs.

Blocked until

…atibility

Install the latest iOS SDK version which includes automatic push click handling. Which gives the RN SDK great benefits such as: increased opened push metrics reliability and better compatibility with 3rd party RN push SDKs.
@levibostian levibostian requested a review from a team February 9, 2024 19:58
@@ -8,7 +8,7 @@
"react-native": "src/index",
"source": "src/index",
"expoVersion": "",
"cioNativeiOSSdkVersion": "= 2.9.2",
"cioNativeiOSSdkVersion": "= 2.11.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would appreciate it if you could run pod update and run the sample apps before merging once iOS changes are live. This will ensure our main branch has the updated state for both the SDK and the sample apps.

Copy link
Contributor

@Shahroz16 Shahroz16 Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to Rehans suggestion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I ran pod update in the sample app update PRs (1, 2) and will push the Podfile.lock file updates in those PRs.

@@ -8,7 +8,7 @@
"react-native": "src/index",
"source": "src/index",
"expoVersion": "",
"cioNativeiOSSdkVersion": "= 2.9.2",
"cioNativeiOSSdkVersion": "= 2.11.0",
Copy link
Contributor

@Shahroz16 Shahroz16 Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to Rehans suggestion

@levibostian levibostian merged commit 514b719 into main Feb 12, 2024
7 checks passed
@levibostian levibostian deleted the levi/reliable-open-metrics branch February 12, 2024 15:57
github-actions bot pushed a commit that referenced this pull request Feb 12, 2024
## [3.4.0](3.3.2...3.4.0) (2024-02-12)

### Features

* increase opened metrics reliability and 3rd party push SDK compatibility ([#236](#236)) ([514b719](514b719))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants