Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix in-app site id #341

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Oct 2, 2024

part of: MBL-539, MBL-538, MBL-546

Changes

  • Used siteId from .env file to fix in-app messaging
  • Exposed inAppMessaging module in TS files
  • Uncommented in-app listener code
  • Removed unnecessary google-services.json.example file
  • Removed --legacy-peer-deps workaround from APN sample

@mrehan27 mrehan27 requested a review from Shahroz16 October 2, 2024 08:57
@mrehan27 mrehan27 self-assigned this Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • FCM: 341.4.0 (28797760)
  • APN: 341.4.0 (28797760)

Comment on lines +14 to +15
"preinstall": "npm run dev:update",
"ci:install": "npm run preinstall && npm ci"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think they are not needed due to the react native version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we now user newer versions so longer need to install legacy dependencies

@mrehan27 mrehan27 merged commit 9f71af9 into feature/cdp-main Oct 2, 2024
9 checks passed
@mrehan27 mrehan27 deleted the rehan/rn-android-fixes branch October 2, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants