Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: in-app messaging fixes and improvements #342

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Oct 3, 2024

part of: MBL-538, MBL-546
blocked by: customerio/customerio-ios#821

Changes

  • Exposed push and in-app modules in TS files
  • Renamed in-app messaging native module classes to match TS files expectations
  • Cleaned up SDK initialization in iOS native files
  • Simplified parsing of configs in native files
  • Included in-app messaging native files
  • Simplified iOS logger to align with Android
  • Refactored some code and moved it to different files for improved readability
  • Removed unnecessary constants, TODOs, and unused code
  • Updated lock and project files

@mrehan27 mrehan27 requested a review from Shahroz16 October 3, 2024 06:35
@mrehan27 mrehan27 self-assigned this Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • FCM: 342.5.0 (28804839)
  • APN: 342.5.0 (28804839)

ios/wrappers/utils/AnyCodable.swift Outdated Show resolved Hide resolved
@mrehan27 mrehan27 merged commit 8d64ba5 into feature/cdp-main Oct 7, 2024
9 checks passed
@mrehan27 mrehan27 deleted the rehan/mbl-538-in-app-ios branch October 7, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants