Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev 367 add GitHub actions #4

Merged
merged 11 commits into from
Feb 14, 2024
Merged

Dev 367 add GitHub actions #4

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d7d6fad
Add github actions, DEV-367
iranimij Feb 5, 2024
2cae55c
Fix GitHub actions, DEV-367
iranimij Feb 5, 2024
cd63221
Add Int tests, DEV-367
iranimij Feb 5, 2024
7539d1b
Add Int tests, DEV-367
iranimij Feb 5, 2024
4eb01fd
Add Int tests, DEV-367
iranimij Feb 5, 2024
9a492bf
Fix int, DEV-363
iranimij Feb 7, 2024
812a070
Add unit, DEV-367
iranimij Feb 12, 2024
f77e0b5
Add unit, DEV-367
iranimij Feb 12, 2024
d00591b
Add unit tests, DEV-367
iranimij Feb 12, 2024
acdc8c8
Fix typo, DEV-367
iranimij Feb 12, 2024
b9955ef
Update GitHub Action trigger, DEV-367
sprankhub Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/coding-standard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: ExtDN M2 Coding Standard
on: [push, pull_request]

jobs:
static:
name: M2 Coding Standard
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: extdn/github-actions-m2/magento-coding-standard@master
351 changes: 351 additions & 0 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,351 @@
name: ExtDN M2 Integration Tests
on: [ push, pull_request ]
jobs:
integration-tests-2-4-4-p6-8-1:
name: Magento 2-4-4-p6 php 8-1 Integration Tests
iranimij marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.4-p6 (PHP 8.1)
uses: extdn/github-actions-m2/magento-integration-tests/8.1@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.4-p6'
composer_version: '2'
integration-tests-2-4-4-p6-7-4:
name: Magento 2-4-4-p6 php 7-4 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.4-p6 (PHP 7.4)
uses: extdn/github-actions-m2/magento-integration-tests/7.4@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.4-p6'
composer_version: '2'
integration-tests-2-4-4-p5-7-4:
name: Magento 2-4-4-p5 php 7-4 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.4-p5 (PHP 7.4)
uses: extdn/github-actions-m2/magento-integration-tests/7.4@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.4-p5'
composer_version: '2'
integration-tests-2-4-4-p5-8-1:
name: Magento 2.4.4-p5 php 8.1 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.4-p5 (PHP 8.1)
uses: extdn/github-actions-m2/magento-integration-tests/8.1@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.4-p5'
composer_version: '2'
integration-tests-2-4-5-p5-8-1:
name: Magento 2.4.5-p5 php 8.1 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.5-p5 (PHP 8.1)
uses: extdn/github-actions-m2/magento-integration-tests/8.1@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.5-p5'
composer_version: '2'
integration-tests-2-4-5-p5-7-4:
name: Magento 2.4.5-p5 php 7.4 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.5-p5 (PHP 7.4)
uses: extdn/github-actions-m2/magento-integration-tests/7.4@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.5-p5'
composer_version: '2'
integration-tests-2-4-5-p4-7-4:
name: Magento 2.4.5-p4 php 7.4 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.5-p4 (PHP 7.4)
uses: extdn/github-actions-m2/magento-integration-tests/7.4@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.5-p4'
composer_version: '2'
integration-tests-2-4-5-p4-8-1:
name: Magento 2.4.5-p4 php 8.1 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.5-p4 (PHP 8.1)
uses: extdn/github-actions-m2/magento-integration-tests/8.1@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.5-p4'
composer_version: '2'
integration-tests-2-4-6-p3-8-1:
name: Magento 2.4.6-p3 php 8.1 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.6-p3 (PHP 8.1)
uses: extdn/github-actions-m2/magento-integration-tests/8.1@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.6-p3'
composer_version: '2'
integration-tests-2-4-6-p3-8-2:
name: Magento 2.4.6-p3 php 8.2 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.6-p3 (PHP 8.2)
uses: extdn/github-actions-m2/magento-integration-tests/8.2@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.6-p3'
composer_version: '2'
integration-tests-2-4-6-p2-8-2:
name: Magento 2.4.6-p2 php 8.2 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.6-p2 (PHP 8.2)
uses: extdn/github-actions-m2/magento-integration-tests/8.2@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.6-p2'
composer_version: '2'
integration-tests-2-4-6-p2-8-1:
name: Magento 2.4.6-p2 php 8.1 Integration Tests
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
env:
MYSQL_ROOT_PASSWORD: root
ports:
- 3306:3306
options: --tmpfs /tmp:rw --tmpfs /var/lib/mysql:rw --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
es:
image: docker.io/wardenenv/elasticsearch:7.8
ports:
- 9200:9200
env:
'discovery.type': single-node
'xpack.security.enabled': false
ES_JAVA_OPTS: "-Xms64m -Xmx512m"
options: --health-cmd="curl localhost:9200/_cluster/health?wait_for_status=yellow&timeout=60s" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- uses: actions/checkout@v4
- name: M2 Integration Tests with Magento 2 Version 2.4.6-p2 (PHP 8.1)
uses: extdn/github-actions-m2/magento-integration-tests/8.1@master
with:
module_name: CustomGento_YouTubeNoCookie
composer_name: customgento/module-youtube-no-cookie-m2
ce_version: '2.4.6-p2'
composer_version: '2'
10 changes: 10 additions & 0 deletions .github/workflows/mess-detector.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: ExtDN M2 Mess Detector
on: [push, pull_request]

jobs:
phpmd:
name: M2 Mess Detector
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: extdn/github-actions-m2/magento-mess-detector@master
12 changes: 12 additions & 0 deletions .github/workflows/phpstan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: ExtDN M2 PHPStan
on: [push, pull_request]

jobs:
phpstan:
name: M2 PHPStan
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: extdn/github-actions-m2/magento-phpstan@master
with:
composer_name: customgento/module-youtube-no-cookie-m2
3 changes: 3 additions & 0 deletions Plugin/Catalog/Product/ChangeVideoUrlPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ public function __construct(VideoUrlConverter $videoLinkConverter)
$this->videoUrlConverter = $videoLinkConverter;
}

/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function afterGetMediaGalleryImages(Product $product, Collection $collection): Collection
{
$collection->walk(function (DataObject $object) {
Expand Down