Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for AMD64 #6

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat: added support for AMD64 #6

merged 1 commit into from
Apr 17, 2024

Conversation

EloB
Copy link
Contributor

@EloB EloB commented Dec 13, 2023

Stakeholder Overview (learn more)

Right now devcontainer using this feature only works for non new Mac computers.
#5

Risk Estimate (learn more)

[Replace this with a description of the risk, if any, and how the change will be deployed.]

  • Big/complex change?
  • Big splash zone?
  • High stakes if errors occur?
  • Low confidence?
  • Not hidden by feature flag?
  • Negligible risk!

Changes

I make aarch64 architects to download aws-sam-cli-linux-arm64.zip instead of aws-sam-cli-linux-x86_64.zip. I'm a bit uncurtained when these script is ran buildtime or runtime. Never written any feature for devcontainers before.

Updated Dependencies
  • None

Ticket

Monday issue

Screenshots

Notes

Recommended reading: Code Review guide

Optional Tasks

  • Include 🎩 Instructions
  • Update the readme (README.md)
  • Update the API or architecture docs (e.g. docs/api.md)
Library-Specific
  • Increment the changelog (CHANGELOG.md)
  • Increment the version number (lib/version.rb)
  • Release & Tag the version above in Github
Performance
  • Are there any new queries in your change set that might require new indexes?
  • Do any new queries require time-boxing to avoid table-scans when the data grows?

What GIF Best Describes This Pull Request?

@sevetseh28
Copy link

Could we please merge this?

@metaskills
Copy link
Contributor

Yup, give me a moment....

@metaskills metaskills merged commit 0c9d489 into customink:main Apr 17, 2024
@metaskills
Copy link
Contributor

Done, SAM CLI feature is now at 1.2.0

https://github.com/customink/codespaces-features/pkgs/container/codespaces-features%2Fsam-cli

@EloB EloB deleted the patch-1 branch July 3, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants