Mini challenge 5 #109
Mini challenge 5 #109
Conversation
axelzo
commented
Aug 31, 2021
axelzo
commented
There was a problem hiding this comment.
Thanks for this final delivery. I think there are some missing functionality. I was not able to add a video to the favorite list. The favorite pages should display only the videos selected by the user and the related videos should be the rest of the videos on the favorites list. The tests that you added are really good, however, there is still some work to do to get the 70% coverage
| <AuthProvider> | ||
| <Layout> | ||
| <Switch> | ||
| <Route exact path="/favorites"> |
There was a problem hiding this comment.
This and the favorite details page should be private
| <Route exact path="/login"> | ||
| <LoginPage /> | ||
| </Route> | ||
| <Private exact path="/secret"> |
|
|
||
| import { StateContext } from '../../context/State/state'; | ||
|
|
||
| const StyledMenu = styled.nav` |
There was a problem hiding this comment.
You can move the styled components to another file Menu.styled.js and just import all the styles here
|
|
||
| describe('Menu', () => { | ||
| test('should render Home span', async () => { | ||
| const spanLabel = screen.queryByText('HOME'); |
There was a problem hiding this comment.
| const spanLabel = screen.queryByText('HOME'); | |
| const spanLabel = screen.getByText('HOME'); |
query* should be used only when we check for inexistent. See: https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#using-query-variants-for-anything-except-checking-for-non-existence
| const { handleSearch, darkMode } = stateContext; | ||
|
|
||
| return ( | ||
| <Container mode={darkMode ? 1 : 0}> |
There was a problem hiding this comment.
Instead of doing this on every component where you need it, you can create a function and export it. If something change, you just need to change it in one place. Also, as the var is boolean, a better proper name would be isDarkMode
