Feat/mini challenge 4 #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Aug 21, 2021
| it('should to take snapshop', () => { | ||
| expect(wrapper).toMatchSnapshot(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Is on this test the App component fetching the real YouTube Api? seems like that. Remember to avoid real YouTube api calls on tests.
ghost
reviewed
Aug 21, 2021
| const history = useHistory(); | ||
| const { search, setSearch, darkMode, setDarkMode } = useContext(AppContext); | ||
| const [anchorEl, setAnchorEl] = useState(null); | ||
| // const [darkMode, setDarkMode] = useState(false); |
ghost
reviewed
Aug 21, 2021
| const darkMode = screen.getByText(/Dark Mode/i); | ||
| expect(darkMode).toBeInTheDocument(); | ||
| }); | ||
| }); |
ghost
reviewed
Aug 21, 2021
| const thumbnail = screen.getByRole('img'); | ||
| expect(thumbnail).toHaveAttribute('src', props.imageURL); | ||
| }); | ||
| }); |
ghost
reviewed
Aug 21, 2021
| test('Render RelatedVideo component', () => { | ||
| expect(wrapper).not.toBeNull(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
You could add more expects like a related video values
ghost
reviewed
Aug 21, 2021
| const descriptionElement = screen.getByText(correctProps.description); | ||
| expect(descriptionElement).toBeInTheDocument(); | ||
| }); | ||
| }); |
ghost
reviewed
Aug 21, 2021
| test('Render Home Page', () => { | ||
| expect(wrapper).not.toBeNull(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Is on this test fetching the real YouTube api?
ghost
reviewed
Aug 21, 2021
| test('Render Video Template Page', () => { | ||
| expect(wrapper).not.toBeNull(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Is on this test fetching the real YouTube api?
Acceptance Criteria
Bonus Points
Seems like is not present the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.