Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini-Challenge 4: State management #87

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

LuisRamirezHdz
Copy link

c1
c2

@LuisRamirezHdz LuisRamirezHdz changed the title Mini-Challenge 3: State management Mini-Challenge 4: State management Aug 15, 2021
Copy link

@dianaatwizeline dianaatwizeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good PR! Keep up the good work

a: '#fff',
cardBodyHover: '#353434',
};
const GlobalStyle = createGlobalStyle`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional:

Consider moving these styles to a separate file to keep App.component.jsx tidier

@@ -0,0 +1,22 @@
import React, { useContext, useReducer } from 'react';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional:

You can move all the places in which you have dispatch to live inside this file.

You would then need to change value={[store, dispatch]} to be something like value={{store, setSearchTerm, setTheme}} that way you can use it like a normal function on the other files

@LuisRamirezHdz
Copy link
Author

@dianaatwizeline ,
Your feedback helped me to make tidier my project. Can you see the result in the new PR. Any suggestions, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants