Minichallenge5 #98
Open
Minichallenge5 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Aug 29, 2021
public/index.html
Outdated
| @@ -26,6 +26,7 @@ | |||
| <body> | |||
| <noscript>You need to enable JavaScript to run this app.</noscript> | |||
| <div id="root"></div> | |||
| <div id="modal"></div> | |||
There was a problem hiding this comment.
It's ok this div for the modal portal but normally this can be implemented as part of a React component itself
ghost
reviewed
Aug 29, 2021
| Promise.resolve({ | ||
| data: { ...videosMock }, | ||
| }) | ||
| ); |
There was a problem hiding this comment.
axios.mockReturnValue(
Promise.resolve({
data: { ...videosMock },
})If this code is duplicated on another tests, you could figure it out how to reuse it
ghost
reviewed
Aug 29, 2021
| Layout.propTypes = { | ||
| children: PropTypes.element.isRequired, | ||
| }; | ||
|
|
||
| export default Layout; |
ghost
reviewed
Aug 29, 2021
| UPDATE_QUERY_VIDEO, | ||
| ADD_TO_FAVORITES, | ||
| REMOVE_FROM_FAVORITES, | ||
| } from '../../utils/constants'; |
ghost
reviewed
Aug 29, 2021
|
|
||
| firebase.initializeApp(firebaseConfig); | ||
|
|
||
| export { firebase }; |
There was a problem hiding this comment.
Remember to never put credentials on the code.
Try to use Env vars instead always. Please fix this.
There was a problem hiding this comment.
This is because with this credentials, I can use them and access to your firebase data.
Acceptance Criteria
Bonus Points
|
|
Congrats! good job 😄 I leave some comments in order to improve some aspects. Generally it's ok 👌 Try to reach the 70% of test coverage, you almost do it! |
ghost
mentioned this pull request
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application's authentication has been developed using firebase services. the login credentials are:
email: [email protected]password:Rocks!preview link: https://minichallenge5-wizeline-oscar.netlify.app/
Test coverage:
