-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace poetry by uv #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
I will work on the revision of ci workflow (especially for caching) after this merge
I tested it with my workstation, and it worked! The code LGTM!! While the below points may be irrelevant (and might be better to discuss in the other thread), I have heard some confusion from my friends, as explained below.
somewhere near the Start Development section may be user-friendly.
I believe this error is very common for every user. (I faced it again this time lol) Is there anything I can help with? |
@chestnutforestlabo |
Issue URL
cvpaperchallenge#106
Change overview
poetry.lock
byuv.lock
etc).README.md
Dockerfile
. Add some new env variables:UV_TOOL_BIN_DIRECTORY
: Define the directory path where uv Tools are installed. Used to specifyUV_TOOL_BIN_DIR
refered by uv.INSTALL_UV_TOOLS
: If true, installruff
,mypy
,pytest
etc as uv Tools.RUN_UV_SYNC_AT_BUILD_TIME
: Same as previousRUN_POETRY_INSTALL_AT_BUILD_TIME
.How to test
Please follow the instruction written in
README.md
. Note thatpoetry install
command is now replaced byuv sync
.Note for reviewers
Note
In the uv, there is a concept called "Tools". Tools is a feature for managing tools used in development. For example, with Poetry, Ruff was installed as a dev dependency, and you would call it with commands like
poetry run ruff <command>
. However, by using the Tools feature in uv, you can invoke it directly withruff <command>
, eliminating the need to manage Ruff inpyproject.toml
. Instead, tools are installed via uv tool install in the Dockerfile.Note
We still using
poethepoet
as task runner. Task runner feature will be added asuv task
in the future.For detail, please check this issue.