fix: add PyPI classifiers and drop TRY003 noqa on exceptions#791
Merged
Conversation
Closes #789: declare [project].classifiers (Python versions, Apache-2.0 license, Private :: Do Not Upload) so the pyproject classifier checks in make validate no longer skip. Closes #790: extract inline exception messages to local variables so the # noqa: TRY003 suppressions can be removed across builder, portfolio, state, and interpolation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses two Rhiza quality scorecard findings by (1) adding Trove classifiers to the package metadata and (2) removing Ruff TRY003 suppressions by extracting inline exception messages into local variables. It also includes a Rhiza template sync bump (v1.1.2 → v1.1.3), which updates the pinned reusable workflows and brings in a new make install-completions target.
Changes:
- Added
[project].classifiersinpyproject.toml(including thePrivate :: Do Not Uploadmarker used by the release workflow to skip PyPI publishing). - Removed all
# noqa: TRY003sites insrc/by assigning exception messages to local variables before raising. - Synced Rhiza template to v1.1.3 (workflow pins updated; new make completions installer added; older
.claude/commands/*docs removed per template).
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/cvx/simulator/utils/interpolation.py | Extracts TypeError message into a local variable to remove TRY003 suppression. |
| src/cvx/simulator/state.py | Extracts ValueError message into a local variable to remove TRY003 suppression. |
| src/cvx/simulator/portfolio.py | Extracts ValueError messages for missing dates/assets into local variables to remove TRY003 suppressions. |
| src/cvx/simulator/builder.py | Extracts ValueError messages into local variables to remove TRY003 suppressions. |
| pyproject.toml | Adds Trove classifiers under [project] to satisfy classifier validation checks. |
| .rhiza/template.yml | Bumps pinned Rhiza template branch to v1.1.3. |
| .rhiza/template.lock | Updates Rhiza sync lock to v1.1.3 and records the new managed file set. |
| .rhiza/make.d/completions.mk | Adds an install-completions make target for installing shell completion scripts. |
| .rhiza/completions/README.md | Documents quick-install instructions for the new completion target. |
| .github/workflows/rhiza_weekly.yml | Updates reusable workflow pin from v1.1.2 to v1.1.3. |
| .github/workflows/rhiza_sync.yml | Updates reusable workflow pin from v1.1.2 to v1.1.3. |
| .github/workflows/rhiza_scorecard.yml | Updates reusable workflow pin from v1.1.2 to v1.1.3. |
| .github/workflows/rhiza_release.yml | Updates Rhiza action pin to v1.1.3 for release workflow steps. |
| .github/workflows/rhiza_mutation.yml | Updates reusable workflow pin from v1.1.2 to v1.1.3. |
| .github/workflows/rhiza_marimo.yml | Updates reusable workflow pin from v1.1.2 to v1.1.3. |
| .github/workflows/rhiza_fuzzing.yml | Updates reusable workflow pin from v1.1.2 to v1.1.3. |
| .github/workflows/rhiza_codeql.yml | Updates reusable workflow pin from v1.1.2 to v1.1.3. |
| .github/workflows/rhiza_ci.yml | Updates reusable workflow pin from v1.1.2 to v1.1.3. |
| .github/workflows/rhiza_book.yml | Updates reusable workflow pin from v1.1.2 to v1.1.3. |
| .github/workflows/rhiza_benchmark.yml | Updates reusable workflow pin from v1.1.2 to v1.1.3. |
| .claude/commands/rhiza_update.md | Removes template-managed Claude command documentation (no longer in synced file set). |
| .claude/commands/rhiza_release.md | Removes template-managed Claude command documentation (no longer in synced file set). |
| .claude/commands/rhiza_quality.md | Removes template-managed Claude command documentation (no longer in synced file set). |
| .claude/commands/rhiza_book.md | Removes template-managed Claude command documentation (no longer in synced file set). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the two quality-scorecard findings filed after the v1.1.3 boost.
[project].classifiersinpyproject.toml(Development Status, Intended Audience,License :: OSI Approved :: Apache Software License, Python 3 / 3.11 / 3.12, Topic, andPrivate :: Do Not Upload). The two classifier checks inmake validateno longer skip (34 passed, previously 32 passed + 2 skipped).builder.py,portfolio.py,state.py, andutils/interpolation.py, removing every# noqa: TRY003suppression insrc/.Verification
make fmt✅ (ruff clean, no TRY003 suppressions remain)make validate✅ (34 passed, 0 skipped)make test✅ (88 passed, 100% coverage)uv build✅ (SPDX license + License classifier build cleanly)🤖 Generated with Claude Code