This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Fixing a crash an and UI issue #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spurrious mouse movement events squashed
carlossanlop
pushed a commit
to ChayoteJarocho/WebPageScreensaver
that referenced
this pull request
Mar 21, 2019
…r has multiple monitors, but then changes to 1 monitor, the preferences form shows the single screen tab list empty, instead of showing all the previously saved websites. By moving two function calls inside PreferencesForm_Load outside the if/else, we ensure that switching from 1 to multi monitors, and back, will always show the expected list of pages in the expected tabs.
|
Sorry for the weird mess with the list of commits. Here's what happened: I tried to test webstylecenter's pull request in my machine and ended up pushing it to my fork, only to realize somewhat late that this PR was getting updated every time my fork was getting updated (I'm fairly new to git). |
|
@cwc any chance you could review this? |
PrefsByScreenUserControl does not have the correct size to show all the buttons at the same time when inside PreferencesForm. I am facing this issue in a high resolution screen in Windows 10. I fixed it by making sure the sizes are exact. I also made sure that the sub-form would stay in the same place when switching tabs.
I realized that when the user has multiple monitors, but then changes to 1 monitor, the preferences form shows the single screen tab list empty, instead of showing all the previously saved websites. By moving two function calls inside PreferencesForm_Load outside the if/else, we ensure that switching from 1 to multi monitors, and back, will always show the expected list of pages in the expected tabs.
Fix crash and UI issue
Sort and remove usings. Rename namespace. Fix a nullability issue. Add SetHighDpiMode call, which is added by default in new WinForms apps. Use ToUpperInvariant to check arguments. Clean spaces.
Sort and remove usings. Rename namespace.
Rename namespace. Remove unnecessary global using. Point default URL to this fork. Spacing.
Sort and remove usings, move them to top. Rename namespace. Update reference to regkey in Program. Spacing.
Rename namespace. Sort and remove usings.
Rename namespace. Spacing.
Sort and remove usings. Rename namespace. Temporarily substitute Navigate call to NavigateToString to prevent build failure. May not be the right call.
Rename namespace. Upgrade obsolete WebBrowser to new WebView2, which is supported in 5.0 and uses Edge. Add BeginInit and EndInit calls for the new WebView2. Spacing.
Upgrade to WebView2. At the time of this commit, Edge Canary is a dependency of this app, but this may change soon when WebView2 gets a stable release.
…, but not for Edge.
Alter the layout and make it look better.
…does not read MouseMove (may be a bug on their side). Ensure sizes of fonts and windows are respected.
… Designer autogenerated code).
…ents is equivalent to opening settings.
Version 2.0.1-Alpha
Final touches to the Readme file
* Add some helpful console messages on wrong arguments. Move code to open preferences form to its own method. * Update WebView2 package version. * TFM must target .NET 5.0 and Windows specifically (due to WinForms). * .gitignore * Bump version * Remove "Any" from sln * Address info Roslyn messages * Clean some unused code, simplify some other, remove regions. * Add new version in readme. * unnecessary parenthesis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44 - NullPointerException when accessing screenUserControls using an index if we expect the list to exist. I made sure the list exists in advance. This change meant that the rules to fill the list were slightly changed, which I addressed and added comments to explain why.
PrefsByScreenUserControl does not have the correct size to show all the buttons at the same time when inside PreferencesForm. I am facing this issue in a high resolution screen in Windows 10. I fixed it by making sure the sizes are exact. I also made sure that the sub-form would stay in the same place when switching tabs.