Dotnetassign#28
Open
Deepakyadav19 wants to merge 13 commits into
Open
Conversation
Deepakyadav19
requested review from
rakshan1996,
sonalichawla16,
techfreakworm and
vishivish18
February 3, 2020 17:00
aasthagoel07
reviewed
Feb 9, 2020
| namespace WebApplication2.controllers | ||
| { | ||
| [Route("api/[controller]")] | ||
| public class ValuesController : Controller |
aasthagoel07
reviewed
Feb 9, 2020
aasthagoel07
reviewed
Feb 9, 2020
| @@ -0,0 +1,9 @@ | |||
| { | |||
There was a problem hiding this comment.
Please add bin folder to .gitignore
aasthagoel07
reviewed
Feb 9, 2020
| } | ||
| // DELETE api/<controller>/5 | ||
| [HttpDelete] | ||
| public ActionResult pdeleteemployee([FromBody]Custom_Models.tcompanycustom data) |
There was a problem hiding this comment.
Same as the other controller. Don't need to pass data parameter only Id would suffice.
Contributor
Author
There was a problem hiding this comment.
only using id for deletion.
aasthagoel07
reviewed
Feb 9, 2020
|
|
||
| // GET: api/<controller> | ||
| [HttpGet] | ||
| public ActionResult getStudent([FromBody]Custom_Models.tcompanycustom data) |
aasthagoel07
reviewed
Feb 9, 2020
| @@ -0,0 +1,73 @@ | |||
| #pragma checksum "C:\Users\deepak.yadav1\source\repos\WebApplication2\WebApplication2\Pages\About.cshtml" "{ff1816ec-aa5e-4d10-87f7-6f4963833460}" "ee9e3a2b396caec39857098be8c15f8288603f03" | |||
There was a problem hiding this comment.
Add obj folder in .gitignore file.
Contributor
Author
There was a problem hiding this comment.
thanks for reviewing aastha.
rakshan1996
reviewed
Feb 11, 2020
|
|
||
| var claims = new[] { | ||
| new Claim(JwtRegisteredClaimNames.Sub, _configuration["Jwt:Issuer"]), | ||
| new Claim(JwtRegisteredClaimNames.Jti, Guid.NewGuid().ToString()), |
There was a problem hiding this comment.
What is the use of GUID in JWT please explain.
Contributor
Author
There was a problem hiding this comment.
in this project it is not required because we are running the project on same device..it is useful for generating a new unique string for every device...
| } | ||
| // DELETE api/<controller>/5 | ||
| [HttpDelete] | ||
| public ActionResult pdeleteemployee([FromBody]Custom_Models.tcompanycustom data) |
|
|
||
| // GET: api/<controller> | ||
| [HttpGet] | ||
| public ActionResult getStudent([FromBody]Custom_Models.tcompanycustom data) |
…n the basis of id
…n the basis of id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for webApi Project.