Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for gesture zone in TraceGesture too #2617

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

snqb
Copy link
Collaborator

@snqb snqb commented Nov 23, 2024

Fixes #2605

Turns out, the problem is not Android-only, it's also reproducible for iOS, see the video attached.
(android video is in the original issue)

IMG_0968.MP4

Thing is, we have the notion of scroll vs gesture zone in the MultiGesture, while we don't track it in TraceGesture, thus leading to half-painted canceled traces. Surely, it doesn't affect functionality, but is kinda misleading, since we have this strong separation of scroll vs gesture zones.
This PR moves out the gesture zone logic to a util file, and reuses it in both MultiGesture and TraceGesture to share the logic.

Copy link
Contributor

@raineorshine raineorshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this makes a lot of sense now that we see it is not Android-specific.

Nice troubleshooting and factoring out the shared functionality.

Thank you!

@raineorshine raineorshine merged commit b279314 into cybersemics:main Nov 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Gesture incorrectly activated in scroll zone
2 participants