Check for gesture zone in TraceGesture
too
#2617
Merged
+24
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2605
Turns out, the problem is not Android-only, it's also reproducible for iOS, see the video attached.
(android video is in the original issue)
IMG_0968.MP4
Thing is, we have the notion of scroll vs gesture zone in the
MultiGesture
, while we don't track it inTraceGesture
, thus leading to half-painted canceled traces. Surely, it doesn't affect functionality, but is kinda misleading, since we have this strong separation of scroll vs gesture zones.This PR moves out the gesture zone logic to a util file, and reuses it in both
MultiGesture
andTraceGesture
to share the logic.