feat: configure excluded propagate labels/annotations #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
force-pushed
the
propagate-exclude-labels-annotations
branch
2 times, most recently
from
2040d4b
to
77b97db
Compare
erikgb
force-pushed
the
propagate-exclude-labels-annotations
branch
from
77b97db
to
8829a67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an implementation of #53. I have tried to keep changes to a minimum though it seems like the code could benefit from some simple refactorings after this change.
I struggled to find good names for the new config props, so please let me know if you have better suggestions!
The change is theoretically not 100% backwards compatible, as
strings.Contains(k, "kubernetes.io/")will potentially exclude more thanpath.Match("*kubernetes.io/*", key), but IMO it should give the same results for typical labels, at least https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/.Closes #53