Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: small fixes #6541

Merged
merged 4 commits into from
Jan 22, 2025
Merged

review: small fixes #6541

merged 4 commits into from
Jan 22, 2025

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jan 7, 2025 •
edited
Loading

Hopefully the final set of Cylc Review changes.

Closes #6171
Addresses #3441

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
review: handle UTF-8 characters in log files
c4f5f8b 
* Assume UTF-8.
* Replace any unknown characters to avoid errors.
* Closes cylc#6171
@oliver-sanders
review: handle workflow IDs with non-ASCII characters.
b708330 
* Addresses cylc#3441
* Patch a urllib method that does not support non-ASCII characters.
* Search functionality will not work, this is challenging to fix under
  Python 2.
@oliver-sanders
review: restrict symlink scope
e4da0b6
@oliver-sanders oliver-sanders added this to the 7.8.x milestone Jan 7, 2025
@oliver-sanders oliver-sanders self-assigned this Jan 7, 2025
@oliver-sanders oliver-sanders changed the title Cylc review++ review: small fixes Jan 7, 2025
oliver-sanders
oliver-sanders commented Jan 7, 2025
View reviewed changes
lib/cylc/url.py
Comment on lines +1 to +5
# This code is derived from the cPython "urllib" module and retains its
# original license.
#
# Python software and documentation are licensed under the
# Python Software Foundation License Version 2.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpmatthews, can you ok this.

Sadly I couldn't achieve the required changes via hot patching.

The original code can be found here (2.7) https://github.com/python/cpython/blob/8d21aa21f2cbc6d50aab3f420bb23be1d081dac4/Lib/urllib.py#L1269

And the license here: https://github.com/python/cpython/blob/v2.7.18/LICENSE#L62

hjoliver
hjoliver approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliver-sanders oliver-sanders requested a review from wxtim January 8, 2025 08:37
@oliver-sanders oliver-sanders mentioned this pull request Jan 22, 2025
Open
8 tasks
wxtim
wxtim reviewed Jan 22, 2025
View reviewed changes
lib/cylc/review.py

# BAD
>>> CylcReviewService._check_link_path(
... os.path.expanduser('~/cylc-run/elephant'), 'shrew'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a member of the Afrotherium clade elephant shrews are more closely related to elephants than shrews.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@wxtim wxtim merged commit f7928c2 into cylc:7.8.x Jan 22, 2025
@oliver-sanders oliver-sanders deleted the cylc-review++ branch January 22, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
7.8.x
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @hjoliver @wxtim