Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency vuetify to v3.6.8 #1785

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 7, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
vuetify (source) 3.5.14 -> 3.6.8 age adoption passing confidence

Release Notes

vuetifyjs/vuetify (vuetify)

v3.6.8

Compare Source

v3.6.7

Compare Source

🔧 Bug Fixes
🧪 Labs

v3.6.6

Compare Source

🔧 Bug Fixes
🔄 Reverts
  • Revert "fix(colors): apply theme-on-surface override for bg text color" (1b56e4e)
🧪 Labs

v3.6.5

Compare Source

🔧 Bug Fixes
  • VDataTable: add missing hide-default-header/footer props (#​19774) (a6340ac)
  • VFileInput: allow dirty prop to trigger dirty state (85c41db), closes #​19699
  • VStepper: add missing hover and focus styling (b45ab1a)
  • VStepper: add missing non-linear styles (da6d5f3)
  • VStepper: only show edit icon if editable and selected (34bb202)
  • VStepper: do not spread raw property onto VStepperItem (3d9deb7)
🧪 Labs

v3.6.4

Compare Source

🔧 Bug Fixes
🧪 Labs

v3.6.3

Compare Source

🔄 Reverts

v3.6.2

Compare Source

🔧 Bug Fixes

v3.6.1

Compare Source

See v3.6 Release here

🚀 Features
  • VConfirmEdit/VEmptyState/VFab/VSpeedDial/VSparkline: promote from labs (c8a03cd)
🔧 Bug Fixes
  • VSnackbar: return correct children (5056034)

v3.6.0

Compare Source

v3.6.0 (Nebula)

Welcome to the v3.6.0 release of Vuetify!


Hero

💪 Support Vuetify Development

Vuetify is an open source MIT project that has been made possible due to the generous contributions by our sponsors and backers. If you are interested in supporting this project, please consider:

📖 Table of Contents

📑 Upgrade guide

  • If you want to opt out of the mobile data table view, set the mobile prop to false
  • Remove any manual imports of Labs components that were promoted as of this release

🏅 Component promotions

The following components have been promoted to the core framework from labs:

confirm-edit

The confirm edit component is a powerful tool that allows you to confirm changes to a field before they are saved. This is especially useful in scenarios where you want to prevent accidental changes to a field.

empty-state

The empty state component is a simple way to display a message when a list or page is empty. This is useful for informing users that there is no data to display.

fab

The floating action button is a layout aware component that is always visible on the screen. It can also be used inline in conjunction with cards and lists.

sparkline

The sparkline component is a simple way to display a small chart inline with text. This is useful for displaying trends or other data in a compact format.

speed-dial

The speed dial component is a floating action button that expands into a menu of actions. This is useful for providing quick access to common actions in a compact format.

💯 Release notes

🚀 Features
🔧 Bug Fixes
  • layout: translate full amount if element and layout size is 0 (99ea55d)
  • VDataTable: add missing scss variable for loading opacity (69b5cc8)
  • VDialog: adjust styling to better match material spec (383bbdc)
  • VNavigationDrawer: don't restrict elementSize when location is top or bottom (1ee802d)
  • VOverlay: move targetRef out of props (5e40cc8), closes #​19685
🧪 Labs

v3.5.18

Compare Source

🔧 Bug Fixes
  • locale: ko translations (#​19687) (a063f94)
  • useDirectiveComponent: cannot read properties of undefined (#​19693) (b9a588f)
  • VDatePicker: stay on current month when selecting multiple (2d13e36)
  • VSnackbar: make touchstart listener passive (24d1066)
  • VSnackbar: conditionally load layout styles (9504efa), closes #​19717
🧪 Labs

v3.5.17

Compare Source

🔧 Bug Fixes
🔄 Reverts
  • Revert "fix(VProgressLinear): remove locationStyles" (78fa9b9), closes #​19658
🧪 Labs

v3.5.16

Compare Source

🔧 Bug Fixes
  • date: startOfWeek/endOfWeek does not respect locale (#​19587) (2cb1ae5)
  • icons: console warn for missing aliases instead of throwing error (82abf1b)
  • rounded: apply rounded-0 for false value (3feeb77), closes #​16601
  • router: empty string to represent real empty "to" (#​19614) (3f301b5), closes #​19549
  • VBottomNavigation: color animation delay (4a033e8)
  • VBtn: apply center ripple when using the icon prop (#​19577) (e1e6065), closes #​17376
  • VDataTable: skip default sort if custom function returns null (d368340)
  • VDialog: focus content element after opening (1f3c823), closes #​18779
  • VFileInput: don't apply input color to chips (4bac07d)
  • VProgressLinear: remove locationStyles (3f50694)
  • VSelect: auto scroll to selected item when using hotkeys (#​19593) (2bb1c07), closes #​19574
🧪 Labs

v3.5.15

Compare Source

🔧 Bug Fixes
🧪 Labs

Configuration

📅 Schedule: Branch creation - "on the 7th day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 7, 2024
@renovate renovate bot changed the title fix(deps): update dependency vuetify to v3.6.3 fix(deps): update dependency vuetify to v3.6.4 May 7, 2024
@renovate renovate bot force-pushed the renovate/vuetify-3.x branch 8 times, most recently from 6226584 to 894c4ae Compare May 10, 2024 20:23
@renovate renovate bot changed the title fix(deps): update dependency vuetify to v3.6.4 fix(deps): update dependency vuetify to v3.6.5 May 10, 2024
@MetRonnie MetRonnie requested review from MetRonnie and removed request for MetRonnie May 13, 2024 11:29
@MetRonnie MetRonnie self-assigned this May 13, 2024
@MetRonnie MetRonnie added this to the 2.6.0 milestone May 13, 2024
@MetRonnie MetRonnie added blocked stop-updating Prevent Renovate from continuously updating this PR labels May 13, 2024
@MetRonnie MetRonnie mentioned this pull request May 13, 2024
5 tasks
@MetRonnie MetRonnie removed the stop-updating Prevent Renovate from continuously updating this PR label May 30, 2024
@renovate renovate bot changed the title fix(deps): update dependency vuetify to v3.6.5 fix(deps): update dependency vuetify to v3.6.8 May 30, 2024
@MetRonnie MetRonnie added the stop-updating Prevent Renovate from continuously updating this PR label May 30, 2024
@MetRonnie MetRonnie removed stop-updating Prevent Renovate from continuously updating this PR blocked labels May 31, 2024
@@ -18,15 +18,11 @@
import { markRaw } from 'vue'

const state = () => ({
drawer: null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1️⃣ For some reason, in Vuetify 3.6, trying to base the drawer visibility state off the vuex store broke resizing the drawer: vuetifyjs/vuetify#19925

See next comment for how I worked around this

Comment on lines +24 to +25
/** Global state of navigation drawer visibility */
const drawer = ref(false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2️⃣ This replaces the entry in the vuex store

Copy link
Contributor Author

renovate bot commented May 31, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

// Prevent Vuetify-provided transitions to ensure responsiveness
el.style.transition = 'none'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to CSS

/** @type {import('vue').Ref<HTMLElement>} template ref */
const resizeBar = ref(null)

when(resizeBar, () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using when waits until the template ref is available. I think we could use onMounted instead, but maybe not now that some Vuetify components are using <Suspense> - see vuetifyjs/vuetify#19736 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work ok. The target region for resizing is very narrow and can be obscured by scroll bars, but this isn't new, opened a separate issue.

Comment on lines -26 to -28
/* this is not in our styles/material-dashboard, so we need to force-override */
-webkit-box-shadow: none !important;
box-shadow: none !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was outdated, wasn't doing anything

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a visible drop shadow when opening the draw in the workspace view from its collapsed state (i.e. via the toggle button in the top left), but this is fine.

@@ -68,11 +67,14 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
</template>

<script>
Copy link
Contributor

@markgrahamdawson markgrahamdawson Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent a bit of time yesterday trying to make this into <script setup> but was struggling with these bits

export default {
  components: {
    Workflows,
    'c-header': Header
  },

not sure how to rename a component like this in Vue3

mode: import.meta.env.MODE,
version: pkg.version,

don't know where to put these.

Its not necessary anyway

Copy link
Member

@MetRonnie MetRonnie Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to specify components in <script setup>, just import them e.g. import CHeader from '@/components/cylc/Header.vue'

You could do const mode = import.meta.env.MODE and just use pkg.version directly in the template

@oliver-sanders oliver-sanders merged commit e4b8785 into master Aug 14, 2024
8 checks passed
@oliver-sanders oliver-sanders deleted the renovate/vuetify-3.x branch August 14, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants