Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement - Save Filter States #209

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Enhancement - Save Filter States #209

merged 3 commits into from
Oct 15, 2021

Conversation

CodesAreHonest
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Features
  • Enhancements

Description

  • Saving local file and export graph data should save and load the filter state.

Test Plan

  1. Refactor graph/thunk related test cases to support different test scenarios.
  2. Improve code coverage of importJson thunk to ensure the new feature added does not break other features.

Does this PR introduce breaking change?

  • No

Closing Issue

close #208

@CodesAreHonest CodesAreHonest added the enhancement New Request label Oct 15, 2021
@CodesAreHonest CodesAreHonest self-assigned this Oct 15, 2021
@CodesAreHonest CodesAreHonest requested a review from timlrx October 15, 2021 02:02
timlrx
timlrx approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@timlrx timlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@CodesAreHonest CodesAreHonest merged commit e844460 into develop Oct 15, 2021
@CodesAreHonest CodesAreHonest deleted the feature/save-filter-states branch December 22, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timlrx timlrx timlrx approved these changes

Assignees

@CodesAreHonest CodesAreHonest

Labels
enhancement New Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodesAreHonest @timlrx