remove obsolete TypeScript standalone example pre Cypress 4.4.0 #5265
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
|
nagash77
approved these changes
May 22, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the reference and link to the obsolete TypeScript "find the standalone example" in Tooling > TypeScript > Examples using Cypress
3.8.3before native TypeScript support was released with Cypress4.4.0.As stated on the Cypress documentation page Tooling > TypeScript > History:
4.4.0 Added support for TypeScript without needing your own transpilation through preprocessors.
https://github.com/cypress-io/add-cypress-custom-command-in-typescript uses the npm module @bahmutov/add-typescript-to-cypress which contains the outdated statement in its README > Why?:
"Cypress is awesome, but does not come with TypeScript support right out of the box. Instead you need to install either Cypress webpack preprocessor or Cypress browserify preprocessor and configure them to transpile TypeScript spec files."
Suggestions
The presence of this example is causing confusion. See cypress-io/add-cypress-custom-command-in-typescript#124.
The https://github.com/cypress-io/add-cypress-custom-command-in-typescript/blob/master/README.md file should be updated with current information and the repository https://github.com/cypress-io/add-cypress-custom-command-in-typescript should be archived.
@bahmutov/add-typescript-to-cypress could also be encouraged to update its README so it reflects Cypress after the release of version 4.4.0 on April 13, 2020.