fix: patch enhanced-resolve when installed as production dependency #27583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When upgrading to webpack 5, webpack/enhanced-resolve looks for the
pnpapi
in their resolver factory. This is likely due to webpack 5 shipping with their pnp plugin, which tries to resolve to itself. There is a proposed fix, but until then we just need to patch theenhanced-resolve
library to discover thepnp
process invoked from the command line. see webpack/enhanced-resolve#263 for root issue. We were already patching this with out update to webpack 5, but the mistake was not patching this as a production level dependency. That is what this PR resolves.Steps to test
follow the steps in #27562 with this binary 5bd41d6. Tests should work as expected
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?