packages/server

packages/server/eslint.config.ts

@@ -0,0 +1,32 @@
+import { baseConfig } from '../../eslint.config'
+import globals from 'globals'
+
+export default [
+  ...baseConfig,
+  {
+    ignores: ['**/fixtures/**/*'],
+  },
+  {
+    languageOptions: {
+      parserOptions: {
+        projectService: false,
+        project: './eslint.tsconfig.json',
+      },
+      globals: {
+        ...globals.node,
+      },
+    },
+  },
+  {
+    files: ['test/**'],
+    languageOptions: {
+      globals: {
+        sinon: 'readonly',
+        nock: 'readonly',
+        mockery: 'readonly',
+        proxyquire: 'readonly',
+        supertest: 'readonly',
+      },
+    },
+  },
+]

packages/server/eslint.tsconfig.json

@@ -0,0 +1,8 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noEmit": true,
+    "allowJs": true
+  },
+  "include": ["**/*"]
+}

packages/server/lib/browsers/cdp-connection.ts

@@ -65,21 +65,24 @@ export class CDPConnection {
 
   get ws () {
     // this is reached into by browser-cri-client to detect close events - needs rethinking
-    return (this._connection as { _ws?: WebSocket})._ws
+    return (this._connection as { _ws?: WebSocket })._ws
   }
 
   on<T extends CdpEvent> (event: T, callback: CDPListener<T>) {
     this.debug('attaching event listener to cdp connection', event)
 
     this._emitter.on(event, callback)
   }
+
   addConnectionEventListener<T extends CDPConnectionEvent> (event: T, callback: CDPConnectionEventListener<T>) {
     this.debug('adding connection event listener for ', event)
     this._emitter.on(event, callback)
   }
+
   off<T extends CdpEvent> (event: T, callback: CDPListener<T>) {
     this._emitter.off(event, callback)
   }
+
   removeConnectionEventListener<T extends CDPConnectionEvent> (event: T, callback: CDPConnectionEventListener<T>) {
     this._emitter.off(event, callback)
   }

packages/server/lib/browsers/cdp_automation.ts

@@ -378,7 +378,6 @@ export class CdpAutomation implements CDPClient {
     })
   }
 
-  // eslint-disable-next-line @cypress/dev/arrow-body-multiline-braces
   private _updateFrameTree = (client: CriClient, eventName) => async () => {
     debugVerbose(`update frame tree for ${eventName}`)
 

packages/server/lib/browsers/chrome.ts

@@ -551,7 +551,7 @@ export = {
     // first allows us to connect the remote interface,
     // start video recording and then
     // we will load the actual page
-    const launchedBrowser = await launch(browser, 'about:blank', port, args, launchOptions.env) as unknown as BrowserInstance & { browserCriClient: BrowserCriClient}
+    const launchedBrowser = await launch(browser, 'about:blank', port, args, launchOptions.env) as unknown as BrowserInstance & { browserCriClient: BrowserCriClient }
 
     la(launchedBrowser, 'did not get launched browser instance')
 

packages/server/lib/browsers/firefox.ts

@@ -326,7 +326,7 @@ const defaultPreferences = {
   'dom.timeout.enable_budget_timer_throttling': false,
 
   // allow getUserMedia APIs on insecure domains
-  'media.devices.insecure.enabled':	true,
+  'media.devices.insecure.enabled': true,
   'media.getusermedia.insecure.enabled': true,
 
   'marionette.log.level': launcherDebug.enabled ? 'Debug' : undefined,

packages/server/lib/browsers/memory/cgroup-v1.ts

@@ -17,7 +17,7 @@ const getTotalMemoryLimit = async () => {
  * @returns object of memory stats
  */
 const convertRawStats = (rawStats: string): { total_inactive_file: string } => {
-  const stats = rawStats.split('\n').filter(Boolean).reduce((acc, arr): { total_inactive_file: string} => {
+  const stats = rawStats.split('\n').filter(Boolean).reduce((acc, arr): { total_inactive_file: string } => {
     const stat = arr.split(' ')
 
     acc[stat[0]] = stat[1]

packages/server/lib/browsers/memory/index.ts

@@ -251,7 +251,7 @@ export const calculateMemoryStats: () => Promise<void> = measure(async () => {
  * @param automation - the automation client used to collect garbage
  * @param test - the current test
  */
-const checkMemoryPressureAndLog = async ({ automation, test }: { automation: Automation, test: { title: string, order: number, currentRetry: number }}) => {
+const checkMemoryPressureAndLog = async ({ automation, test }: { automation: Automation, test: { title: string, order: number, currentRetry: number } }) => {
   await checkMemoryPressure(automation)
 
   gcLog.testTitle = test.title

packages/server/lib/browsers/utils.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-redeclare */
 import Bluebird from 'bluebird'
 import _ from 'lodash'
 import type { FoundBrowser } from '@packages/types'
@@ -55,10 +54,10 @@ const getMajorVersion = (version) => {
 }
 
 const defaultLaunchOptions: {
-  preferences: {[key: string]: any}
+  preferences: { [key: string]: any }
   extensions: string[]
   args: string[]
-  env: {[key: string]: any}
+  env: { [key: string]: any }
 } = {
   preferences: {},
   extensions: [],
@@ -318,8 +317,8 @@ const parseBrowserOption = (opt) => {
   }
 }
 
-function ensureAndGetByNameOrPath(nameOrPath: string, returnAll: false, browsers?: FoundBrowser[]): Bluebird<FoundBrowser>
-function ensureAndGetByNameOrPath(nameOrPath: string, returnAll: true, browsers?: FoundBrowser[]): Bluebird<FoundBrowser[]>
+function ensureAndGetByNameOrPath (nameOrPath: string, returnAll: false, browsers?: FoundBrowser[]): Bluebird<FoundBrowser>
+function ensureAndGetByNameOrPath (nameOrPath: string, returnAll: true, browsers?: FoundBrowser[]): Bluebird<FoundBrowser[]>
 
 async function ensureAndGetByNameOrPath (nameOrPath: string, returnAll = false, prevKnownBrowsers: FoundBrowser[] = []) {
   const browsers = prevKnownBrowsers.length ? prevKnownBrowsers : (await getBrowsers())

packages/server/lib/capture.js

@@ -21,15 +21,13 @@ const stdout = function () {
     process.log = function (str) {
       logs.push(str)
 
-      // eslint-disable-next-line prefer-rest-params
       return log.apply(this, arguments)
     }
   }
 
   process.stdout.write = function (str) {
     logs.push(str)
 
-    // eslint-disable-next-line prefer-rest-params
     return write.apply(this, arguments)
   }
 

packages/server/lib/cloud/artifacts/screenshot_artifact.ts

@@ -18,8 +18,8 @@ const createScreenshotArtifact = async (filePath: string, uploadUrl: string): Pr
 }
 
 export const createScreenshotArtifactBatch = (
-  screenshotUploadUrls: {screenshotId: string, uploadUrl: string}[],
-  screenshotFiles: {screenshotId: string, path: string}[],
+  screenshotUploadUrls: { screenshotId: string, uploadUrl: string }[],
+  screenshotFiles: { screenshotId: string, path: string }[],
 ): Promise<IArtifact[]> => {
   const correlatedPaths = screenshotUploadUrls.map(({ screenshotId, uploadUrl }) => {
     const correlatedFilePath = screenshotFiles.find((pathPair) => {

packages/server/lib/cloud/network/parse_error.ts

@@ -5,6 +5,7 @@ export class ParseError extends Error {
   constructor (public readonly originalError: Error, message?: string) {
     super(message)
   }
+
   static isParseError (err: Error & { kind: string }): err is ParseError {
     return err.kind === ParseErrorKind
   }

packages/server/lib/cloud/network/put_fetch.ts

@@ -20,8 +20,8 @@ type PutOptions = PutInit & {
   parse?: ParseKind
 }
 
-export async function putFetch <
-  TReturn extends any
+export async function putFetch<
+  TReturn,
 > (input: RequestInfo | URL, options: PutOptions = { parse: 'json' }): Promise<TReturn> {
   const {
     parse,

packages/server/lib/cloud/upload/stream_stalled_error.ts

@@ -10,7 +10,7 @@ export class StreamStalledError extends Error {
     super(`Stream stalled: failed to transfer ${chunkSizeKB} kilobytes over the previous ${maxActivityDwellTime}ms`)
   }
 
-  public static isStreamStalledError (error: Error & {kind?: any}): error is StreamStalledError {
+  public static isStreamStalledError (error: Error & { kind?: any }): error is StreamStalledError {
     return error.kind === StreamStalledErrorKind
   }
 }

packages/server/lib/controllers/iframes.ts

@@ -61,7 +61,6 @@ export const iframesController = {
 
     nodeProxy.web(req, res, {}, (e) => {
       if (e) {
-        // eslint-disable-next-line
         debug('Proxy request error. This is likely the socket hangup issue, we can basically ignore this because the stream will automatically continue once the asset will be available', e)
       }
     })

packages/server/lib/modes/interactive.ts

@@ -10,7 +10,6 @@ import { makeGraphQLServer } from '@packages/graphql/src/makeGraphQLServer'
 import { globalPubSub, getCtx, clearCtx } from '@packages/data-context'
 import { telemetry } from '@packages/telemetry'
 
-// eslint-disable-next-line no-duplicate-imports
 import type { WebContents } from 'electron'
 import type { LaunchArgs, Preferences } from '@packages/types'
 
@@ -91,7 +90,7 @@ export = {
         y: 'appY',
         devTools: 'isAppDevToolsOpen',
       },
-      onBlur (this: {webContents: WebContents}) {
+      onBlur (this: { webContents: WebContents }) {
         if (this.webContents.isDevToolsOpened()) {
           return
         }

packages/server/lib/modes/results.ts

@@ -1,5 +1,3 @@
-/* eslint-disable @cypress/dev/arrow-body-multiline-braces */
-
 import _ from 'lodash'
 import type { FoundBrowser, SpecWithRelativeRoot } from '@packages/types'
 import path from 'path'

packages/server/lib/modes/run.ts

@@ -1,4 +1,4 @@
-/* eslint-disable no-console, @cypress/dev/arrow-body-multiline-braces */
+/* eslint-disable no-console */
 import _ from 'lodash'
 import pkg from '@packages/root'
 import path from 'path'
@@ -432,7 +432,6 @@ async function listenForProjectEnd (project: ProjectBase, exit: boolean): Promis
       earlyExitTerminator.waitForEarlyExit(project, exit),
     ]).then((results) => {
       if (exit === false) {
-        // eslint-disable-next-line no-console
         console.log('not exiting due to options.exit being false')
       } else {
         resolve(results)

packages/server/lib/privileged-commands/privileged-channel.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-redeclare
 /* global window */
 (({ browserFamily, isSpecBridge, key, namespace, scripts, url, win = window, documentDomainContext }) => {
   /**

packages/server/lib/routes.ts

@@ -267,7 +267,6 @@ export const createCommonRoutes = ({
       // their own app.js files + spec.js files
       nodeProxy.web(req, res, {}, (e) => {
         if (e) {
-        // eslint-disable-next-line
         debug('Proxy request error. This is likely the socket hangup issue, we can basically ignore this because the stream will automatically continue once the asset will be available', e)
         }
       })

packages/server/lib/server-base.ts

@@ -486,7 +486,7 @@ export class ServerBase<TSocket extends SocketE2E | SocketCt> {
     return ios
   }
 
-  createHosts (hosts: {[key: string]: string} | null = {}) {
+  createHosts (hosts: { [key: string]: string } | null = {}) {
     return _.each(hosts, (ip, host) => {
       return evilDns.add(host, ip)
     })

packages/server/lib/socket-base.ts

@@ -20,7 +20,7 @@ import runEvents from './plugins/run_events'
 import type { OTLPTraceExporterCloud } from '@packages/telemetry'
 import { telemetry } from '@packages/telemetry'
 import type { Automation } from './automation'
-// eslint-disable-next-line no-duplicate-imports
+
 import type { Socket } from '@packages/socket'
 
 import type { RunState, CachedTestState, ProtocolManagerShape } from '@packages/types'

packages/server/lib/util/async_retry.ts

@@ -4,9 +4,9 @@ type RetryOptions = {
   shouldRetry?: (err?: Error) => boolean
 }
 
-export function asyncRetry <
+export function asyncRetry<
   TArgs extends any[],
-  TResult extends any,
+  TResult,
 > (fn: (...args: TArgs) => Promise<TResult>, options: RetryOptions) {
   return async (...args: TArgs): Promise<TResult> => {
     let attempt = 0

packages/server/lib/util/ensure-url.ts

@@ -9,7 +9,7 @@ const debug = debugModule('cypress:server:ensure-url')
 
 type RetryOptions = {
   retryIntervals: number[]
-  onRetry(o: {delay: number, attempt: number, remaining: number}): void
+  onRetry(o: { delay: number, attempt: number, remaining: number }): void
 }
 
 export const retryIsListening = (urlStr: string, options: RetryOptions) => {

packages/server/lib/util/fs.ts

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 import Bluebird from 'bluebird'
 import fsExtra from 'fs-extra'
 

packages/server/lib/util/print-run.ts

@@ -608,13 +608,11 @@ export const logUploadManifest = (artifacts: IArtifact[], protocolCaptureMeta: {
     [ArtifactKinds.PROTOCOL]: 'Test Replay',
   }
 
-  // eslint-disable-next-line no-console
   console.log('')
   terminal.header('Uploading Cloud Artifacts', {
     color: ['blue'],
   })
 
-  // eslint-disable-next-line no-console
   console.log('')
 
   const video = artifacts.find(({ reportKey }) => reportKey === ArtifactKinds.VIDEO)
@@ -686,14 +684,12 @@ export const logUploadResults = (results: ArtifactUploadResult[], protocolFatalE
     [ArtifactKinds.PROTOCOL]: 'Test Replay',
   }
 
-  // eslint-disable-next-line no-console
   console.log('')
 
   terminal.header('Uploaded Cloud Artifacts', {
     color: ['blue'],
   })
 
-  // eslint-disable-next-line no-console
   console.log('')
 
   results.forEach(({ key, ...report }, i, { length }) => {

packages/server/lib/util/stream_buffer.ts

@@ -117,13 +117,16 @@ function streamBuffer (initialSize = 2048) {
 
       return readable
     }
+
     unpipeAll () {
       buffer = null // aggressive GC
       _.invokeMap(this.readers, 'unpipe')
     }
+
     _buffer () {
       return buffer
     }
+
     _finished () {
       return finished
     }

packages/server/package.json

@@ -11,7 +11,7 @@
     "dev": "node index.js",
     "docker": "cd ../.. && WORKING_DIR=/packages/server ./scripts/run-docker-local.sh",
     "postinstall": "patch-package",
-    "lint": "eslint --ext .js,.jsx,.ts,.tsx,.json, .",
+    "lint": "eslint .",
     "rebuild-better-sqlite3": "electron-rebuild -f -o better-sqlite3",
     "repl": "node repl.js",
     "start": "node ../../scripts/cypress open --dev --global",

packages/server/test/integration/cypress_spec.js

@@ -1,4 +1,5 @@
 /* eslint-disable no-console */
+// eslint-disable-next-line no-redeclare
 /*global globalThis*/
 require('../spec_helper')
 const _ = require('lodash')

packages/server/test/unit/cloud/network/put_fetch_spec.ts

@@ -41,7 +41,7 @@ describe('cloud/network/put_fetch', () => {
 
       describe('and parseJSON flag is true', () => {
         it('resolves with the parsed object', async () => {
-          const res = await fetch<{'content': string}>(url)
+          const res = await fetch<{ 'content': string }>(url)
 
           expect(res).to.eq(jsonObj)
         })

packages/server/test/unit/config_spec.js

@@ -890,7 +890,7 @@ describe('lib/config', () => {
 
       context('retries', () => {
         // need to keep the const here or it'll get stripped by the build
-        // eslint-disable-next-line no-unused-vars
+
         const cases = [
           [{ retries: null }, 'with null', null],
           [{ retries: 3 }, 'when a number', null],

packages/server/test/unit/util/suppress_warnings_spec.ts

@@ -40,9 +40,8 @@ describe('lib/util/suppress_warnings', function () {
 
     suppress()
 
-    // eslint-disable-next-line no-buffer-constructor
     new Buffer(0)
-    // eslint-disable-next-line no-buffer-constructor
+
     new Buffer('asdf')
 
     expect(emitWarning).not.to.be.called