-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow version 10 of the babel-loader peer dependency #31218
base: develop
Are you sure you want to change the base?
fix: allow version 10 of the babel-loader peer dependency #31218
Conversation
|
I used the v9 babel-loader dependency update as a reference. |
ba3a5fb
to
526b767
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cek-roadmunk-tempo. Thank you for opening a PR. This is currently a breaking change where this PR stands, but adding the code suggestion below would fix that. Would you also be able to update the babel-loader
dependency in webpack-preprocessor
if you have time just to help with test coverage?
Co-authored-by: Bill Glesias <bglesias@gmail.com>
I'll work on this next. |
Concerning the failed check, is there anything I should do? |
@cek-roadmunk-tempo I don't think so. It looks like build flake which sometimes happens with contributor PRs. If it continues to be a problem, I will investigate |
Additional details
There is a dependency between babel-loader and @cypress/webpack-preprocessor. The max babel-loader version allowed is v9. This PR bumps the allowed version to v10.
Here are the breaking changes in babel-loader v10:
^18.20.0 || ^20.10.0 || >=22.0.0
and webpack requirement to>= 5.61.0
output.hashFunction
as loader cache hasherAs far as I can ascertain, this should have no negative effects on this package or cypress.
Steps to test
I used
npm link
to install the modified@cypress/webpack-preprocessor
package into my own cypress project with babel-loader v10. I didn't encounter any issues.How has the user experience changed?
No change.
PR Tasks
cypress-documentation
?type definitions
?