Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow version 10 of the babel-loader peer dependency #31218

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

cek-roadmunk-tempo
Copy link

@cek-roadmunk-tempo cek-roadmunk-tempo commented Mar 4, 2025

Additional details

There is a dependency between babel-loader and @cypress/webpack-preprocessor. The max babel-loader version allowed is v9. This PR bumps the allowed version to v10.

Here are the breaking changes in babel-loader v10:

  • bump node requirement to ^18.20.0 || ^20.10.0 || >=22.0.0 and webpack requirement to >= 5.61.0
  • breaking: use output.hashFunction as loader cache hasher

As far as I can ascertain, this should have no negative effects on this package or cypress.

Steps to test

I used npm link to install the modified @cypress/webpack-preprocessor package into my own cypress project with babel-loader v10. I didn't encounter any issues.

How has the user experience changed?

No change.

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@cek-roadmunk-tempo cek-roadmunk-tempo changed the title allow v10 of babel-loader fix: allow version 10 of the babel-loader peer dependency Mar 4, 2025
@cek-roadmunk-tempo cek-roadmunk-tempo changed the title fix: allow version 10 of the babel-loader peer dependency dependency: allow version 10 of the babel-loader peer dependency Mar 4, 2025
@cek-roadmunk-tempo cek-roadmunk-tempo changed the title dependency: allow version 10 of the babel-loader peer dependency fix: allow version 10 of the babel-loader peer dependency Mar 4, 2025
@cek-roadmunk-tempo
Copy link
Author

I used the v9 babel-loader dependency update as a reference.

@cek-roadmunk-tempo cek-roadmunk-tempo force-pushed the fix/allow-babel-loader-v10-peer-dep branch from ba3a5fb to 526b767 Compare March 4, 2025 23:40
@cek-roadmunk-tempo cek-roadmunk-tempo marked this pull request as ready for review March 5, 2025 00:04
Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cek-roadmunk-tempo. Thank you for opening a PR. This is currently a breaking change where this PR stands, but adding the code suggestion below would fix that. Would you also be able to update the babel-loader dependency in webpack-preprocessor if you have time just to help with test coverage?

Co-authored-by: Bill Glesias <bglesias@gmail.com>
@cek-roadmunk-tempo
Copy link
Author

cek-roadmunk-tempo commented Mar 14, 2025

Would you also be able to update the babel-loader dependency in webpack-preprocessor if you have time just to help with test coverage?

I'll work on this next.

@AtofStryker AtofStryker self-requested a review March 14, 2025 19:35
@cek-roadmunk-tempo
Copy link
Author

Concerning the failed check, is there anything I should do?

@AtofStryker
Copy link
Contributor

Concerning the failed check, is there anything I should do?

@cek-roadmunk-tempo I don't think so. It looks like build flake which sometimes happens with contributor PRs. If it continues to be a problem, I will investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants