docs: typescript migration guide #31243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
docs/ts-upgrade-guide
|
| Run status |
|
| Run duration | 18m 06s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
15
|
Flaky
|
7
|
Pending
|
1208
|
Skipped
|
0
|
Passing
|
31274
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.87%
|
|
|---|---|
|
Untested elements
|
185
|
|
Tested elements
|
161
|
Accessibility
92.63%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
875
|
Tests for review
The first 5 failed specs are shown, see all 238 specs in Cypress Cloud.
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ... > stops waiting when an xhr request is canceled |
| |||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Screenshots
|
|
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| cy.origin - cookie login > Max-Age > past max-age -> not logged in |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > does not throw again when 2nd alias doesn't reference a route |
Test Replay
|
|
The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.
jennifer-shehane
approved these changes
Mar 10, 2025
AtofStryker
approved these changes
Mar 10, 2025
cacieprins
commented
Mar 11, 2025
MikeMcC399
reviewed
Mar 12, 2025
MikeMcC399
reviewed
Mar 12, 2025
MikeMcC399
reviewed
Mar 12, 2025
guides/typescript.md
Outdated
|
|
||
| - No unnecessary `.js` in the repository | ||
| - The repository passes linting based on the `@typescript-eslint/recommended-type-checked` rule set | ||
| - The repository uses `@eslint/stylistic` to format |
There was a problem hiding this comment.
@eslint/stylistic isn't an npm module
There is a website https://eslint.style/ which refers to plugins @stylistic/eslint-plugin
A link either to the website or to an existing npm module would be clearer here
mschile
approved these changes
Mar 13, 2025
Co-authored-by: Mike McCready <[email protected]>
Co-authored-by: Mike McCready <[email protected]>
cacieprins
commented
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Adds a guide for writing TypeScript and migrating JS to TS
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?