dependency: [WIP] Update Electron to 34 #31260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloneOfAlex
approved these changes
Mar 11, 2025
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
electron-34
|
| Run status |
|
| Run duration | 17m 41s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
29
|
Skipped
|
0
|
Passing
|
787
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
63.64%
|
|
|---|---|
|
Untested elements
|
30
|
|
Tested elements
|
56
|
Accessibility
96.2%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
195
|
jennifer-shehane
changed the title
CloneOfAlex
approved these changes
Mar 12, 2025
| @@ -279,6 +279,7 @@ | |||
| "@types/react": "18.3.12", | |||
| "browserify-sign": "4.2.2", | |||
| "devtools-protocol": "0.0.1413303", | |||
| "node-abi": "3.74.0", | |||
There was a problem hiding this comment.
See this note as to why this was necessary: https://github.com/cypress-io/cypress/pull/31260/files#diff-43831bef862964fca0c4c1b68381da0539c3892c9b356e7db2a19cf25cfc4295R90
| @@ -305,7 +305,8 @@ export class ProjectConfigIpc extends EventEmitter { | |||
| // If they've got TypeScript installed, we can use | |||
| // ts-node for CommonJS | |||
| // ts-node/esm for ESM | |||
| if (hasTypeScriptInstalled(this.projectRoot)) { | |||
| // If we're in a cy in cy project, we will handle registering typescript directly in the server entry point | |||
| if (!process.env.CYPRESS_INTERNAL_E2E_TESTING_SELF_PARENT_PROJECT && hasTypeScriptInstalled(this.projectRoot)) { | |||
There was a problem hiding this comment.
Electron must have changed something with their spawn call. We're unsure what, but when cy-in-cy all of this logic is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?