Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix deprecation warnings and refactor react reporter to use hooks #31284

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Mar 13, 2025

  • Closes N/A

Additional details

Since update @packages/reporter to React 18, there have been several console warnings about the deprecation of class components and other API methods being removed in new versions of React. This create additional noise when trying to develop. This PR cuts over the remaining class components to functional components to lessen the deprecation messages printed to the console.

Steps to test

This change should be passive, but we want to make sure all the updated components are still working correctly

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Mar 13, 2025

cypress    Run #61049

Run Properties:  status check failed Failed #61049  •  git commit d17dcf5810: fix reporter tests and run in CI
Project cypress
Branch Review chore/fix_react_18_deprecation_warnings
Run status status check failed Failed #61049
Run duration 16m 23s
Commit git commit d17dcf5810: fix reporter tests and run in CI
Committer AtofStryker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 5
Tests that were flaky  Flaky 8
Tests that did not run due to a developer annotating a test with .skip  Pending 144
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 6614
View all changes introduced in this branch ↗︎
UI Coverage  0%
  Untested elements 4  
  Tested elements 0  
Accessibility  97.09%
  Failed rules  0 critical   1 serious   0 moderate   0 minor
  Failed elements 6  

Tests for review

Failed  runnables.cy.ts • 1 failed test • reporter

View Output

Test Artifacts
runnables > runnable-header (unified) > adds a scroll listener in open mode Test Replay Screenshots
Failed  runner/sessions.ui.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
runner/cypress sessions.open_mode.spec > persists global session and does not persists spec session when selecting a different spec Test Replay Screenshots
Failed  settings.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
App: Settings > Cloud Settings > shows deferred remote cloud data after navigating from a run Test Replay Screenshots
Failed  cypress-in-cypress-e2e.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress In Cypress E2E > stops correctly running spec while switching specs Test Replay Screenshots
Failed  cypress-origin-communicator.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Test Replay Screenshots
Flakiness  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
cy.origin - cookie login > Max-Age > past max-age -> not logged in
    </td>
  </tr></table>
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > stops waiting when an xhr request is canceled
    </td>
  </tr></table>
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Screenshots
Flakiness  studio/studio.cy.ts • 2 flaky tests • app-e2e

View Output

Test Artifacts
Cypress Studio > does not create a new test if the Save test modal is closed Test Replay Screenshots
Cypress Studio > does not remove the studio url parameters if saving fails Test Replay Screenshots
Flakiness  create-from-component.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
... > runs generated spec Test Replay Screenshots

The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.

@AtofStryker AtofStryker force-pushed the chore/fix_react_18_deprecation_warnings branch from a1802a4 to d17dcf5 Compare March 17, 2025 19:29
@AtofStryker
Copy link
Contributor Author

some issues on the reporter lifecycle events that need to be figured out which is the hold up on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant