fix: pass --no-experimental-require-module for node 20.19.0+ versions

[samtsai]

• Closes: no issue was created but same fix as fix: error loading config file with node 22.12.0 #30730

Additional details

Introduced by node latest 20.19.0 release that also enables require(esm) by default
https://nodejs.org/en/blog/release/v20.19.0

Tested locally with added version check

Steps to test

Same fix and steps as #30730

How has the user experience changed?

No

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[jennifer-shehane]

@samtsai Thanks for the PR. We're expecting this logic to be removed with Cypress 15, but seems reasonable to add for now. Going to see how the tests run.

[samtsai]

@samtsai Thanks for the PR. We're expecting this logic to be removed with Cypress 15, but seems reasonable to add for now. Going to see how the tests run.

I figured since node 20 will be around for another year it'd be helpful for others

[alexsch01]

same logic needs to be done for --no-experimental-detect-module - see #30084

[alexsch01]

if (this.nodeVersion && (semver.gte(this.nodeVersion, '22.12.0') || semver.gte(this.nodeVersion, '20.19.0'))) {

Don't think this is the correct logic

wouldn't 22.0.0 get matched by this?

[samtsai]

if (this.nodeVersion && (semver.gte(this.nodeVersion, '22.12.0') || semver.gte(this.nodeVersion, '20.19.0'))) {

Don't think this is the correct logic

wouldn't 22.0.0 get matched by this?

Good point, I will update it to just match within the (20.19 - 20.x)

[samtsai]

@alexsch01 I've limited the check to 20.19.0 and greater, but not including 21.

[alexsch01]

logic looks good to me

[alexsch01]

Lets wait and see what happens from nodejs/node#57520

[samtsai]

Lets wait and see what happens from nodejs/node#57520

nice, the community has responded 😄

[AtofStryker]

Thank you for submitting a PR for this @samtsai! I am kind of surprised this made its way into a minor version of node as this seems quite disruptive 😅 .

Most the suggestions I have are minor. Let me know if you are able to address!

[AtofStryker]

just waiting on CI results but everything looks good on my end! Thank you!