chore: parameterize persist artifacts #32972
Merged
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
AtofStryker
approved these changes
Nov 20, 2025
AtofStryker
reviewed
Nov 20, 2025
Contributor
AtofStryker
left a comment
AtofStryker
left a comment
There was a problem hiding this comment.
@cacieprins the mksnapshot command failed when I ran the pipeline? Do we need to configure something else additionally https://app.circleci.com/pipelines/github/cypress-io/cypress-publish-binary/16576/workflows/f5de6c49-b48a-4c9d-9f20-b7b05637e929/jobs/32056
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ci/parameterize-persist-artifacts
|
| Run status |
|
| Run duration | 19m 12s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
10
|
Pending
|
1098
|
Skipped
|
4
|
Passing
|
26733
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
161
|
Accessibility
98%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
kchhotu6444-ops
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Rather than modifying our circle config files, we can now trigger artifact persistence via a manual Circle workflow invocation.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Add a
force-persist-artifactspipeline parameter and update artifact persistence logic to honor it and simplify branch checks.force-persist-artifacts(boolean, defaultfalse) to/.circleci/config.ymland/.circleci/src/pipeline/@pipeline.yml.setup_should_persist_artifactsto setSHOULD_PERSIST_ARTIFACTSwhenforce-persist-artifactsistrue; otherwise persist ondevelopandrelease/*branches; remove legacy branch exception.Written by Cursor Bugbot for commit 1f79368. This will update automatically on new commits. Configure here.