Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for Debian sid, and ability to test a packaged cyrus-imapd instead of building it from source #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sdelafond
Copy link

By default, and in order to be backward-compatible (so upstream doesn't
have to modify any of its existing CI calls), functions.sh and
testscript.sh will continue building cyrus from source and testing that.

If the BUILD_CYRUS_FROM_SOURCE variable is set to something else than
"yes", however, the Debian package will be used instead; this is what
the maintainers of cyrus-imapd in Debian use for autopkgtest.

A second extra environment variable, CASSANDANEOPTS, is also added: it
is set to "Cyrus::ImapTest" in Debian, in order to limit the range of
tests being run. Its default value is "", once again to keep the
behavior backward-compatible with the previous implementation.

FTR:

  commit 76bfc82
  Author: ellie timoney <[email protected]>
  Date:   Wed Sep 25 11:09:08 2019 +1000

      functions.sh: don't ignore cassandane 'make' failures

      (why was this ever a thing??)
…s. "testing distribution package" (Debian)

By default, and in order to be backward-compatible (so upstream doesn't
have to modify any of its existing CI calls), functions.sh and
testscript.sh will continue building cyrus from source and testing that.

If the BUILD_CYRUS_FROM_SOURCE variable is set to something else than
"yes", however, the Debian package will be used instead; this is what
the maintainers of cyrus-imapd in Debian use for autopkgtest.

A second extra environment variable, CASSANDANEOPTS, is also added: it
is set to "Cyrus::ImapTest" in Debian, in order to limit the range of
tests being run. Its default value is "", once again to keep the
behavior backward-compatible with the previous implementation.
@rjbs
Copy link
Contributor

rjbs commented Dec 10, 2024

Thanks for this. I've been doing a bunch of overhaul of the Dockerfile, and I realize that this PR is quite old. Sorry about the wait.

I'm doing a test run now to make sure we can build on sid. Apart from that, I think I'll need to come back to look at this one in the near future. It seems reasonable, but as we're moving around a few other things, I want to keep things in a well-understood order…

@rjbs rjbs force-pushed the master branch 2 times, most recently from 2dafe76 to d7277d6 Compare December 15, 2024 17:49
@rjbs
Copy link
Contributor

rjbs commented Jan 2, 2025

I think maybe this PR has sort lost steam, which I acknowledge will be because it was so long ignored.

I think the goal here was to make it possible to test an installed-from-apt cyrus-imapd for running the Cassandane test suite. I assume this was so that the Debian packagers could use this image's test suite for testing their packaged cyrus-imapd. Is that so?

If so, I bet we can make some progress. I will close this issue in a week or two if I don't hear back, but of course it can be re-opened.

@Neustradamus
Copy link

Important Debian 13 will be enter in freeze period soon.

It is the moment to create a new cyrus-sasl and cyrus-imapd release versions.

@rjbs
Copy link
Contributor

rjbs commented Jan 7, 2025

This repository isn't part of Debian or, as far as I know, how Debian makes releases. I don't understand the point of your comment.

@Neustradamus
Copy link

@rjbs: It is cyrus-docker and Debian Sid is Debian Unstable, the step before Debian Testing.

In this period (January 2025), Debian Testing is now Debian 13 "Trixie" which enters in freeze period in few days.

Debian 13 is the next generation of Debian after Debian 12 (2023).

Debian has new major release every 2 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants