Rename between users #4758
Merged
Rename between users #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksmurchison
requested changes
Dec 2, 2023
brong
force-pushed
the
rename-between-users
branch
from
cb08357 to
9752dd1
Compare
|
CI is fully passing now on my machine (including JMAP-Tester, I added that to my machine). The issue was setting the foldermodseq for the newmbentry too early, so it didn't get included in changes correctly. |
ksmurchison
approved these changes
Dec 12, 2023
brong
added
backport-to-3.8
|
@elliefm I've added backport tags to this - it fixes an otherwise bad bug that came in with uuid mailboxes |
will make rename_nocopy code align
We need the new mbentry since we're not creating a full mailbox; and we also need to syntheticaly make sure we're updating the new conversations db. This mirrors the logic from mailbox_rename_copy.
brong
force-pushed
the
rename-between-users
branch
from
9752dd1 to
a6535bb
Compare
|
This doesn't backport well to 3.6, because the test Quota.storage_convquota_immediate relies on the If we do want to backport this to 3.6, we'll either also need #4203 and #4209 (at least), or need to drop this test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue in Fastmail production where a user had done:
rename user.A.foo user.B.foofollowed by
rename user.B.foo user.A.fooWhich had caused conversations to be all broken because we weren't correctly detecting this case in the mailbox_rename_nocopy (uuid paths) case.
This PR adds a test for the case, then code to make it work (and yes, I did tdd this!)