mailbox: no hierarchy walk when deleting uuid mailboxes#4764
Merged
elliefm merged 3 commits intocyrusimap:masterfrom Dec 11, 2023
Merged
mailbox: no hierarchy walk when deleting uuid mailboxes#4764elliefm merged 3 commits intocyrusimap:masterfrom
elliefm merged 3 commits intocyrusimap:masterfrom
Conversation
elliefm
force-pushed
the
v39/supposedly-empty-directory
branch
from
1a8d899 to
55a1f4e
Compare
This error should only occur when an actual problem happens, not routinely for nearly every delete
rsto
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the hierarchy walk component of
mailbox_delete_cleanup()when the mailbox being deleted uses UUID storage (which has no hierarchy on disk). This prevents it inadvertently trying to delete the single character hash directories and then logging spurious "Remove of supposedly empty directory %s failed" messages when they're inevitably not empty. At Fastmail, this message is currently spuriously logged around 100,000 times a day...