fix typo in promstatsd error message #4773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message so far read cyrus/promstatsd[17284]: Prometheus metrics are not being tracked. Set prometheus_enable in imapd.conf and I added that setting to my imapd.conf, which didn't solve the problem. Further investigation resulted in detecting that the parameter actually is called "prometheus_enabled" and not "prometheus_enable". Let's fix the error message to avoid others falling into the same trap.
ksmurchison
approved these changes
Dec 18, 2023
|
Looks like this wasn't actually merged? Just approved, and then the branch deleted. I'm not sure what to make of that. |
|
On Tue, Dec 19, 2023 at 02:26:06PM -0800, elliefm wrote:
Looks like this wasn't actually merged? Just approved, and then the branch deleted. I'm not sure what to make of that.
Sorry, I thought it was merged, so I deleted my repository. No point in keeping hundreds of repositories
around in my github account, just for sending one line fixes.
I've now re-created the repo with the [rebased] branch. No idea how to re-open this PR.
I usually work more in project that use gerrit. The entire github workflow is a bit alien to me,
especially with approval != merge
…--
- Harald Welte ***@***.***> https://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
|
|
Thanks for the clarification and resubmission! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message so far read
cyrus/promstatsd[17284]: Prometheus metrics are not being tracked. Set prometheus_enable in imapd.conf
and I added that setting to my imapd.conf, which didn't solve the problem. Further investigation resulted in detecting that the parameter actually is called "prometheus_enabled" and not "prometheus_enable".
Let's fix the error message to avoid others falling into the same trap.