Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xapian_wrap.cpp: query verbatim for terms using fullwidth form #4782

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

rsto
Copy link
Member

@rsto rsto commented Jan 4, 2024

This works around an issue with Xapian 1.5 when indexing and querying for text containing codepoints in the Halfwidth and Fullwidth Forms Unicode block.

It does so by querying for both the terms as generated by the query parser and the form as generated by the term generator during indexing. This only is applied if the query actually contains at least on codepoint in that Unicode block.

The issue has been reported to the Xapian mailing list at https://lists.xapian.org/pipermail/xapian-devel/2024-January/003410.html

@rsto rsto requested review from ksmurchison and elliefm January 4, 2024 17:17
Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about Xapian, so I'll trust that this fixes the problem

This works around an issue with Xapian 1.5 when indexing and
querying for text containing codepoints in the Halfwidth and
Fullwidth Forms Unicode block.

It does so by querying for both the terms as generated by the
query parser and the form as generated by the term generator
during indexing. This only is applied if the query actually
contains at least on codepoint in that Unicode block.

The issue has been reported to the Xapian mailing list at
https://lists.xapian.org/pipermail/xapian-devel/2024-January/003410.html

Signed-off-by: Robert Stepanek <[email protected]>
@rsto rsto force-pushed the xapian_query_fullwidth_halfwidth branch from 990b350 to 6c0fc9b Compare January 5, 2024 09:01
@rsto rsto merged commit 803e081 into master Mar 12, 2024
2 checks passed
@rsto rsto deleted the xapian_query_fullwidth_halfwidth branch March 12, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants