mboxlist.c: add 'U' field (user inboxid) to mbentry_t #4838
+101
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksmurchison
force-pushed
the
mboxlist_inboxid
branch
3 times, most recently
from
c2240b9
to
b4b5e04
Compare
ksmurchison
force-pushed
the
mboxlist_inboxid
branch
from
b4b5e04
to
a02794d
Compare
brong
approved these changes
Mar 12, 2024
ksmurchison
force-pushed
the
mboxlist_inboxid
branch
3 times, most recently
from
ea83841
to
19c4d9c
Compare
|
@brong I added 'inboxid' code to mailbox_create() which fixes the CaldavAlarm replication tests failing on the v5 branch if you want to re-review. |
ksmurchison
force-pushed
the
mboxlist_inboxid
branch
from
19c4d9c
to
ecc9746
Compare
|
@brong Does this look ready? If so, I'll flag it as include-in-fastmail |
|
@ksmurchison yes, this looks great - just had a full read through |
brong
approved these changes
Jun 19, 2024
ksmurchison
force-pushed
the
mboxlist_inboxid
branch
from
ecc9746
to
5ea6581
Compare
|
@brong This PR was more complete than my other one so I closed it. However, the old one used an 'R' tag for 'root_mailboxid'. And this one uses 'U' for 'user_inboxid'. Do you have a preference? I'd like to just use 'inboxid' but 'I' is already used for 'uniqueid'. We could use 'B' or 'X'. |
ksmurchison
force-pushed
the
mboxlist_inboxid
branch
from
5ea6581
to
23f7955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.