Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential fixes for debian time_t transition #4887

Closed

Conversation

elliefm
Copy link
Contributor

@elliefm elliefm commented Apr 14, 2024

This draft PR is for producing patches so that @guimard can check for whether they fix #4876 or not.

@dilyanpalauzov
Copy link
Contributor

https://wiki.debian.org/ReleaseGoals/64bit-time contains:

Dpkg enabling -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64
Because you have to have LFS if you have 64-bit time_t (glibc enforces this), this goal is a superset of ReleaseGoals/LFS

The latter includes

For projects using autoconf, by adding the AC_SYS_LARGEFILE m4 macro.

This likely means, that Debian compiles with -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64, and irrespective of this AC_SYS_LARGEFILE must be called. But autoconf definition of AC_SYS_LARGEFILE also states “Define ‘_FILE_OFFSET_BITS’ and ‘_LARGE_FILES’ if necessary.” - I do not know if this is necessary.

All that said, I think adjusting to time_t means calling explicitly AC_SYS_LARGEFILE, which is currently not done.

@elliefm
Copy link
Contributor Author

elliefm commented Aug 28, 2024

This is now #5009

@elliefm elliefm closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants