JMAP Email: rewrite JMAP Email to MIME conversion #4902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsto
force-pushed
the
jmap_emailpart_to_mime
branch
from
c343168
to
4d48a1a
Compare
rsto
force-pushed
the
jmap_emailpart_to_mime
branch
4 times, most recently
from
3aa7690
to
b886660
Compare
Turns out that most uses of this function force a newline before the parameter anyway, so don't require the caller to provide the header prefix length. Signed-off-by: Robert Stepanek <[email protected]>
Signed-off-by: Robert Stepanek <[email protected]>
It passed a non-ascii blob as text/plain content.
Email/set now sanitizes bare LF in inlined text bodies, rather than keeping it as-is and using quoted-printable encoding.
A couple of tests created email attachments using binary data without specifying the MIME type of the body part. The new safeguards catch this as inappropriate values for the default text/plain MIME type.
This updates how Email/set{create} creates MIME message from
JMAP Email objects.
- Inline plain text is rewritten before conversion regardless
if its content is sourced from an EmailBodyValue or Blob.
Non-plain text content now never is rewritten, even if it is
defined with in a EmailBodyValue.
- If the charset property for inline plain text declares the
content to be ASCII or UTF-8, then the EmailBodyPart is
rejected for invalid characters.
- The content transfer encoding for "message" media types is
chosen by the media subtype, e.g. "message/rfc822" and
"message/global" are handled differently.
- Bare carriage returns in inline plain text now get expanded
to CRLF, rather than omitted from the body part contents.
- Transfer encoding names are written in lowercase, e.g. "8bit"
rather than "8BIT".
rsto
force-pushed
the
jmap_emailpart_to_mime
branch
from
b886660
to
2f68fe8
Compare
|
This is now part of #4926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates how MIME messages are created from JMAP Email objects for Email/set{create}. Changes include: