DO NOT MERGE: perltidy all the cassandane tiny tests #4964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliefm
reviewed
Jul 10, 2024
| localpart => undef, | ||
| domain => undef, | ||
| }; | ||
| sub new { |
There was a problem hiding this comment.
I prefer when blocks in column 0 (i.e. global function/arrays/hash/etc definitions) have their opening bracket also in column 0 of the next line (which has been Cyrus style forever), like this:
sub new
{
Specifically, I like it because my muscle memory wants to use [[ and ]] to jump between them in vim.
I prefer the opening bracket on the same line everywhere else... unless pushing it to the next line improves readability in context.
|
@rjbs do you plan to continue working on this? shall we close this PR otherwise? |
|
Closed. I'll come back to it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.