Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developer docs: remove note about Test::Unit problems #4974

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

rjbs
Copy link
Collaborator

@rjbs rjbs commented Jul 14, 2024

It is no longer busted on recent perls, as of 0.026.

@rjbs rjbs requested a review from elliefm July 14, 2024 14:15
Copy link
Contributor

@dilyanpalauzov dilyanpalauzov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@@ -60,10 +60,6 @@ Install and configure Cassandane
sudo cpan -i Mail::JMAPTalk
sudo cpan -i Math::Int64

With recent perl versions ``Test::Unit::TestRunner`` cannot be installed with ``cpan``. Download
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing a cpan -i command above, which installs Test::Unit::TestRunner, or is this somehow an indirect, implicit dependency?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of libtest-unit-perl which is generally expected to have been installed by apt-get (or similar) in the previous step. If you haven't used a system package for whatever reason, then it's implied that you'd need to install those dependencies by some other means (such as CPAN). But this list of CPAN modules is the extra stuff that's not available via apt-get, so it's correct that Test::Unit is missing from it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I added cpan-packages in the documentation I was not aware, that first some packages need to be installed over apt-get. In fact I had no apt-get, so I wrote what I have installed with cpan -i.

It is no longer busted on recent perls, as of 0.026.
@rjbs
Copy link
Collaborator Author

rjbs commented Jul 15, 2024

I've amended the commit to mention installing Test::Unit with cpan. After all, it shows libanyevent-perl and installing AnyEvent via CPAN.

Copy link
Member

@brong brong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is good - thanks for adding the extra cpan item.

@brong brong merged commit d7670c6 into cyrusimap:master Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants