Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index Message-ID, References and In-Reply-To headers in Xapian #4977

Merged
merged 10 commits into from
Jul 17, 2024

Conversation

rsto
Copy link
Member

@rsto rsto commented Jul 17, 2024

This indexes the Message-ID, References and In-Reply-To headers in Xapian and makes them available for JMAP Email queries search with the new messageId, references and inReplyTo JMAP filter conditions.

This pull request builds on the changes of #4926

rsto added 9 commits July 17, 2024 14:32
It really didn't belong to global.h in the first place.
Up until now, Cyrus did not convert the contents of header fields
and a couple of iCalendar properties to search form. This required
us to convert those part contents to lower case in the Xapian
wrapper, but we rather want this all proper NFKC-casefolded.

Calling charset_convert on these values before sending them to
the indexer makes sure all indexed text is in proper form.
The query runner might rewrite the search query before running
it, so report the query costs after that.
@rsto rsto changed the base branch from master to cyrus_eai July 17, 2024 12:55
Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xapian is not my strong suit, but loosk sane to me.

@rsto rsto merged commit c4e15bf into cyrusimap:cyrus_eai Jul 17, 2024
@rsto rsto deleted the xapian_add_messageid branch July 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants