-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index Message-ID, References and In-Reply-To headers in Xapian #4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It really didn't belong to global.h in the first place.
Up until now, Cyrus did not convert the contents of header fields and a couple of iCalendar properties to search form. This required us to convert those part contents to lower case in the Xapian wrapper, but we rather want this all proper NFKC-casefolded. Calling charset_convert on these values before sending them to the indexer makes sure all indexed text is in proper form.
The query runner might rewrite the search query before running it, so report the query costs after that.
rsto
force-pushed
the
xapian_add_messageid
branch
from
July 17, 2024 12:57
f412f7b
to
2748016
Compare
rsto
force-pushed
the
xapian_add_messageid
branch
from
July 17, 2024 12:59
2748016
to
904479a
Compare
ksmurchison
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Xapian is not my strong suit, but loosk sane to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This indexes the
Message-ID
,References
andIn-Reply-To
headers in Xapian and makes them available for JMAP Email queries search with the newmessageId
,references
andinReplyTo
JMAP filter conditions.This pull request builds on the changes of #4926