Don't send the "action strings" when notifying #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked do not merge until freeze is over. |
ksmurchison
reviewed
Dec 11, 2024
sieve/script.c
Outdated
| @@ -430,7 +430,7 @@ static int build_notify_message(sieve_interp_t *i, | |||
| static int send_notify_callback(sieve_interp_t *interp, | |||
| void *message_context, | |||
| void *script_context, notify_list_t *notify, | |||
| char *actions_string, | |||
| char *actions_string __attribute__((unused)), | |||
There was a problem hiding this comment.
Do we want to just remove the actions_string parameter all together rather than just commenting out the place where it is used?
ksmurchison
approved these changes
Dec 11, 2024
rjbs
force-pushed
the
cyr-1426-no-action-string
branch
from
31be83b to
1b33afc
Compare
These strings are largely useful for debugging, not end user consumption. (This commit is also in part due to Ricardo Signes, who altered some of the changes from the long-lived Fastmail commit by Bron.)
rjbs
force-pushed
the
cyr-1426-no-action-string
branch
from
1b33afc to
df1111f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These strings are largely useful for debugging, not end user consumption.
(This commit message was written by Ricardo Signes, replacing the previous internal Fastmail commit message. The code change is by Bron Gondwana.)