don't add timezone data in http_caldav_sched.c#5167
Merged
rjbs merged 1 commit intocyrusimap:masterfrom Jan 17, 2025
Merged
Conversation
Contributor
Author
|
Labeled |
ksmurchison
approved these changes
Dec 13, 2024
rjbs
force-pushed
the
cyr-1427-leave-tz-out
branch
2 times, most recently
from
7e5cbf5 to
e041c4b
Compare
We removed this line quite some time ago in Fastmail builds, because we sometimes saw downstream problems with Exchange. Ken Murchison's advice was that in general clients should not (or no longer) be looking at TZ data included in events, anyway. Adding it could cause problems, but probably helps no one. Instead, we'll just leave it be. (This commit message was written by Ricardo Signes, replacing the previous internal Fastmail commit message. The code change is by Bron Gondwana.)
rjbs
force-pushed
the
cyr-1427-leave-tz-out
branch
from
e041c4b to
170aa00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We removed this line quite some time ago in Fastmail builds, because we sometimes saw downstream problems with Exchange.
Ken Murchison's advice was that in general clients should not (or no longer) be looking at TZ data included in events, anyway. Adding it could cause problems, but probably helps no one. Instead, we'll just leave it be.
(This commit message was written by Ricardo Signes, replacing the previous internal Fastmail commit message. The code change is by Bron Gondwana.)