Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCase: workaround for HTTP::Tiny behaviour change #5227

Merged

Conversation

elliefm
Copy link
Contributor

@elliefm elliefm commented Jan 21, 2025

HTTP::Tiny 0.83+ defaults to enabling SSL certificate verification. The Net::DAVTalk modules can't currently configure SSL properly, so tests with a https service configured (ALPN.https_*) fail during setup when HTTP::Tiny is 0.83 or newer.

HTTP::Tiny 0.86+ adds an environment variable for restoring the old default behaviour of not verifying SSL certificates.

This PR sets the environment variable temporarily during setup to stop these tests failing.

Better fix to follow later, once Net::DAVTalk has been updated.

@elliefm elliefm requested a review from ksmurchison January 21, 2025 23:21
@elliefm elliefm mentioned this pull request Jan 21, 2025
@elliefm elliefm merged commit 5f9c2e8 into cyrusimap:master Jan 22, 2025
1 check passed
@elliefm elliefm deleted the v313/cyr-1524-http-tiny-dont-verify-ssl branch January 22, 2025 00:06
@elliefm elliefm added the backport-to-3.12 for PRs that are to be backported to 3.12 label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-3.12 for PRs that are to be backported to 3.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants