Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubsan fixes #5303

Merged
merged 17 commits into from
Feb 20, 2025
Merged

Ubsan fixes #5303

merged 17 commits into from
Feb 20, 2025

Conversation

brong
Copy link
Member

@brong brong commented Feb 19, 2025

I got sick of compiling with ubsan and then not being able to run Cassandane tests, so this fixes a lot of the noise!

@brong brong requested a review from wolfsage February 19, 2025 18:20
wolfsage
wolfsage approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@wolfsage wolfsage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Neat trick with the union for aligned reads. Probably we could use alignas at this point instead but it seems fine.

Thanks for this!

@brong
Copy link
Member Author

brong commented Feb 20, 2025

lgtm. Neat trick with the union for aligned reads. Probably we could use alignas at this point instead but it seems fine.

Thanks for this!

Yeah, this trick was used in places in the code before (may still be) - have fixed a couple more now.

brong added 17 commits February 20, 2025 20:08
@brong
protect qsort with nitems check
6340632 
This avoids passing NULLs to qsort
@brong
conversations: align GUID binary parsing data with a scratch space
10c1fad
@brong
make 1<<31 unsigned
b5e7b21
@brong
ctl_conversationsdb: we don't need to decode basecid
88013e1 
We can just compare the representation, and copy it into place too.
@brong
all the 1<< for userflags (which could be 31)
1286c00
@brong
more ubsan fixes
96a209f
@brong
auth_pts: fix absan (we copy the data anyway)
41b811d
@brong
more ubsan
a49b155
@brong
attachextract: fix NULL dereference!
3c04d35
@brong
align all the 1U<< code
a882785
@brong
ubsan fixes - last ones I hope!
5207b2b
@brong
cyrusdb: fix -O2 compilation
c023529
@brong
cyrusdb_flag: skip base check (found by clang)
344c158
@brong
fix zero+ offset calculation cases (clang -O2)
a304f40
@brong
sanitizer directory: remove double slash
7cccd0a
@brong
Info: clean up sanitizer output when crashing a proc
3fe9be1
@brong
jmap_mail: fix undefined behaviour with if((NULL)++)
c14e806
@brong brong merged commit 1842e53 into cyrusimap:master Feb 20, 2025
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfsage wolfsage wolfsage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brong @wolfsage