CORE-2011 Update max CPU reconciliation in DE job submissions. #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated apps.service.apps.de.jobs.common/reconcile-container-requirements to use 0 for the max CPU request for user submissions if nothing was submitted from the client. This will prevent the maximum CPUs set by the tool from being used in the final job submission, allowing the job services to use their own reasonable default instead (currently 4). A similar check was added for user `memory_limit` requests, which will also allow job services to use their own defaults (VICE jobs will use 8Gi, for example).
psarando
force-pushed
the
CORE-2011-fix-max-cpu-requests
branch
from
d7b49d5
to
082c587
Compare
ianmcorvidae
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
apps.service.apps.de.jobs.common/reconcile-container-requirementsto use0for the max CPU request for user submissions if nothing was submitted from the client.This will prevent the maximum CPUs set by the tool from being used in the final job submission, allowing the job services to use their own reasonable default instead (currently
4).A similar check was added for user
memory_limitrequests, which will also allow job services to use their own defaults (VICE jobs will use8Gi, for example).