Periodic notifications, continued #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcorvidae
commented
Sep 18, 2024
| subject := fmt.Sprintf(PeriodicSubjectFormat, j.Name, starttime, durString) | ||
|
|
||
| msg := fmt.Sprintf( | ||
| PeriodicMessageFormat, | ||
| j.Name, | ||
| j.ID, | ||
| starttime, | ||
| dur, | ||
| durString, |
There was a problem hiding this comment.
This is a small secondary change -- the notification text in the DE was showing "0s" due to the way we were modifying the dur object. It should be showing the same thing as the subject line in the DE/as the email subject, so now it is.
|
Review is still welcome, but I'm going to go ahead and get this in so I can be testing it in QA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should let timelord pass down a run duration to the email template, and allow it to use a specified template for those notifications rather than everything using the status change one. de-mailer PR with an initial template to use there also incoming.