Periodic notification preferences #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase, starting to enable notifications to be sent without request for email
…ets set to 4 hours if 0)
ianmcorvidae
commented
Sep 26, 2024
| @@ -186,7 +188,7 @@ func SendPeriodicNotification(ctx context.Context, j *Job) error { | |||
| durString, | |||
| ) | |||
|
|
|||
| return sendNotif(ctx, j, j.Status, subject, msg, "analysis_periodic_notification") | |||
| return sendNotif(ctx, j, j.Status, subject, msg, j.NotifyPeriodic, "analysis_periodic_notification") | |||
There was a problem hiding this comment.
I haven't actually moved the NotifyPeriodic into the notif_statuses table, because it's static anyway and I didn't really want to write another database migration. The interval is still there, and it's beneficial for it to be since it's used for filtering the list of jobs that may need notification.
slr71
approved these changes
Sep 26, 2024
|
Cool, thanks for giving it a look. I'll get this into QA and then see what I can break, I guess 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should make it so timelord respects the notification preferences stored in the job submission. NotifyPeriodic denotes whether emails should be sent for periodic notifications, not whether the notifications should be sent at all.