Skip to content

fix npm stage CI execution #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alixander merged 1 commit into from
Aug 3, 2026
Merged

fix npm stage CI execution #2795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/npm-stage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,18 @@ jobs:
- name: Install binaryen
run: |
BINARYEN_VERSION="version_123"
curl -fsSL "https://github.com/WebAssembly/binaryen/releases/download/${BINARYEN_VERSION}/binaryen-${BINARYEN_VERSION}-x86_64-linux.tar.gz" | tar -xz
sudo cp "binaryen-${BINARYEN_VERSION}"/bin/* /usr/local/bin/
curl -fsSL "https://github.com/WebAssembly/binaryen/releases/download/${BINARYEN_VERSION}/binaryen-${BINARYEN_VERSION}-x86_64-linux.tar.gz" | tar -xz -C "$RUNNER_TEMP"
sudo cp "$RUNNER_TEMP/binaryen-${BINARYEN_VERSION}"/bin/* /usr/local/bin/
wasm-opt --version

- name: Build and test package
run: |
COLOR=1 ./make.sh js
CI_FORCE=1 CI_MAKE_ROOT=0 COLOR=1 ./make.sh js
cd d2js/js
bun test test/unit

- name: Stage package for review
env:
NPM_PUBLISH_MODE: stage
NPM_VERSION: ${{ inputs.version }}
run: COLOR=1 ./make.sh js
run: CI_FORCE=1 CI_MAKE_ROOT=0 COLOR=1 ./make.sh js
7 changes: 6 additions & 1 deletion d2js/js/ci/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,13 @@ sh_c bun build.js

if [ -n "${NPM_VERSION:-}" ]; then
cp package.json package.json.bak
trap 'rm -f .npmrc; mv package.json.bak package.json' EXIT
PUBLISH_MODE="${NPM_PUBLISH_MODE:-publish}"
if [ "$PUBLISH_MODE" = stage ] && [ -f package-lock.json ]; then
cp package-lock.json package-lock.json.stage.bak
trap 'rm -f .npmrc; mv package.json.bak package.json; mv package-lock.json.stage.bak package-lock.json' EXIT
else
trap 'rm -f .npmrc; mv package.json.bak package.json' EXIT
fi

if [ "$NPM_VERSION" = "nightly" ]; then
echo "Publishing nightly version to npm..."
Expand Down
Loading