Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a test to check for circle ring closure #290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

llamington
Copy link

Adds a test to satisfy #289

@Fil
Copy link
Member

Fil commented Jul 2, 2024

Upgrading the test is not enough; we'll want to add a test for the case that breaks, and fix the generator:

for (var point, t = t0; direction > 0 ? t > t1 : t < t1; t -= step) {

(this should probably store the starting point and repeat it at the end).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants